Skip to content

feat(ast_visit): add Utf8ToUtf16Converter::convert_program method#13341

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-27-feat_ast_visit_add_utf8toutf16converter_convert_program_method
Aug 28, 2025
Merged

feat(ast_visit): add Utf8ToUtf16Converter::convert_program method#13341
graphite-app[bot] merged 1 commit intomainfrom
08-27-feat_ast_visit_add_utf8toutf16converter_convert_program_method

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 27, 2025

Utf8ToUtf16 already has a convert_program method. Add the same method to Utf8ToUtf16Converter (the struct that does the actual conversions).

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Aug 27, 2025
Copy link
Member Author

overlookmotel commented Aug 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2025

CodSpeed Instrumentation Performance Report

Merging #13341 will not alter performance

Comparing 08-27-feat_ast_visit_add_utf8toutf16converter_convert_program_method (bb10c88) with main (33e0e8b)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (59d2c08) during the generation of this report, so 33e0e8b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review August 27, 2025 22:26
@overlookmotel overlookmotel force-pushed the 08-27-feat_ast_visit_add_utf8toutf16converter_convert_program_method branch from 04dec40 to 2f29200 Compare August 27, 2025 23:01
@overlookmotel overlookmotel force-pushed the 08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8 branch from e326655 to 462e488 Compare August 27, 2025 23:01
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 28, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 28, 2025

Merge activity

…13341)

`Utf8ToUtf16` already has a `convert_program` method. Add the same method to `Utf8ToUtf16Converter` (the struct that does the actual conversions).
@graphite-app graphite-app bot force-pushed the 08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8 branch from 462e488 to 59d2c08 Compare August 28, 2025 09:24
@graphite-app graphite-app bot force-pushed the 08-27-feat_ast_visit_add_utf8toutf16converter_convert_program_method branch from 2f29200 to bb10c88 Compare August 28, 2025 09:25
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 28, 2025
Base automatically changed from 08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8 to main August 28, 2025 09:30
@graphite-app graphite-app bot merged commit bb10c88 into main Aug 28, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-27-feat_ast_visit_add_utf8toutf16converter_convert_program_method branch August 28, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants