feat(ast_visit): add Utf8ToUtf16Converter::convert_program method#13341
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 28, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 27, 2025
CodSpeed Instrumentation Performance ReportMerging #13341 will not alter performanceComparing Summary
Footnotes |
04dec40 to
2f29200
Compare
e326655 to
462e488
Compare
This was referenced Aug 27, 2025
Dunqing
approved these changes
Aug 28, 2025
Contributor
Merge activity
|
…13341) `Utf8ToUtf16` already has a `convert_program` method. Add the same method to `Utf8ToUtf16Converter` (the struct that does the actual conversions).
462e488 to
59d2c08
Compare
2f29200 to
bb10c88
Compare
Base automatically changed from
08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8
to
main
August 28, 2025 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Utf8ToUtf16already has aconvert_programmethod. Add the same method toUtf8ToUtf16Converter(the struct that does the actual conversions).