Skip to content

refactor(transformer/typescript): take a Vec rather than take elements of Vec one by one#12462

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-23-refactor_transformer_typescript_take_a_vec_rather_than_take_element_of_vec_one_by_one
Jul 23, 2025
Merged

refactor(transformer/typescript): take a Vec rather than take elements of Vec one by one#12462
graphite-app[bot] merged 1 commit intomainfrom
07-23-refactor_transformer_typescript_take_a_vec_rather_than_take_element_of_vec_one_by_one

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 23, 2025

Only take Vec once rather than take elements of Vec a few times. I guess this can save a few instructions.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 23, 2025
Copy link
Member Author

Dunqing commented Jul 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title refactor(transformer/typescript): take a Vec rather than take element of Vec one by one refactor(transformer/typescript): take a Vec rather than take elements of Vec one by one Jul 23, 2025
@Dunqing Dunqing marked this pull request as ready for review July 23, 2025 03:35
@Dunqing Dunqing requested a review from overlookmotel as a code owner July 23, 2025 03:35
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Instrumentation Performance Report

Merging #12462 will not alter performance

Comparing 07-23-refactor_transformer_typescript_take_a_vec_rather_than_take_element_of_vec_one_by_one (3541739) with 07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier (93a5b76)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
Copy link
Member

Boshen commented Jul 23, 2025

Merge activity

  • Jul 23, 4:12 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 23, 9:37 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier branch from 6891d8f to fd85cf5 Compare July 23, 2025 04:29
@graphite-app graphite-app bot force-pushed the 07-23-refactor_transformer_typescript_take_a_vec_rather_than_take_element_of_vec_one_by_one branch from 569f4b0 to 3b5d29c Compare July 23, 2025 04:29
…nts of `Vec` one by one (#12462)

Only take `Vec` once rather than take elements of `Vec` a few times. I guess this can save a few instructions.
@graphite-app graphite-app bot force-pushed the 07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier branch from fd85cf5 to 93a5b76 Compare July 23, 2025 09:28
@graphite-app graphite-app bot force-pushed the 07-23-refactor_transformer_typescript_take_a_vec_rather_than_take_element_of_vec_one_by_one branch from 3b5d29c to 3541739 Compare July 23, 2025 09:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
Base automatically changed from 07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier to main July 23, 2025 09:36
@graphite-app graphite-app bot merged commit 3541739 into main Jul 23, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-23-refactor_transformer_typescript_take_a_vec_rather_than_take_element_of_vec_one_by_one branch July 23, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants