Skip to content

refactor(transformer/typescript): take a Vec rather than take elements of Vec one by one #12462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 23, 2025
Merged

refactor(transformer/typescript): take a Vec rather than take elements of Vec one by one #12462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/oxc_transformer/src/typescript/enum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,29 +222,28 @@ impl<'a> TypeScriptEnum<'a> {

let mut prev_member_name = None;

for member in members.iter_mut() {
for member in members.take_in(ctx.ast.allocator) {
let member_name = member.id.static_name();

let init = if let Some(initializer) = &mut member.initializer {
let init = if let Some(mut initializer) = member.initializer {
let constant_value =
self.computed_constant_value(initializer, &previous_enum_members, ctx);
self.computed_constant_value(&initializer, &previous_enum_members, ctx);

previous_enum_members.insert(member_name, constant_value);

match constant_value {
None => {
prev_constant_number = None;
let mut new_initializer = initializer.take_in(ast);

IdentifierReferenceRename::new(
param_binding.name,
enum_scope_id,
previous_enum_members.clone(),
ctx,
)
.visit_expression(&mut new_initializer);
.visit_expression(&mut initializer);

new_initializer
initializer
}
Some(constant_value) => match constant_value {
ConstantValue::Number(v) => {
Expand Down
Loading