perf(transformer/typescript): store Atom rather than String for ConstantValue::String#12458
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 23, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ConstantValue::StringAtom rather than String for ConstantValue::String
9ab93fc to
50c3a80
Compare
CodSpeed Instrumentation Performance ReportMerging #12458 will not alter performanceComparing Summary
Footnotes |
9f82de1 to
fb1a5f7
Compare
50c3a80 to
3f5be6b
Compare
fb1a5f7 to
dcb245c
Compare
3f5be6b to
1ea35fa
Compare
1ea35fa to
53ed334
Compare
Contributor
Merge activity
|
…ConstantValue::String` (#12458) The `ConstantValue` would finally be used in the AST, so it can store it as `Atom` rather than `String`, which can be faster and use less memory usage.
53ed334 to
f32c816
Compare
Contributor
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
ConstantValuewould finally be used in the AST, so it can store it asAtomrather thanString, which can be faster and use less memory usage.