refactor(transformer/typescript): simplify evaulating the of value an enum member without an initialzier#12461
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 23, 2025
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12461 will not alter performanceComparing Summary
|
graphite-app
bot
force-pushed
the
07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string
branch
2 times, most recently
from
1ea35fa to
53ed334
Compare
graphite-app
bot
force-pushed
the
07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier
branch
from
6891d8f to
fd85cf5
Compare
… enum member without an initialzier (#12461) Previously, `prev_constant_value` stores a `Option<ConstantValue>`, but we only use `ConstantValue::Number`, so simplify it to store a `Option<f64>`
graphite-app
bot
force-pushed
the
07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string
branch
from
53ed334 to
f32c816
Compare
graphite-app
bot
force-pushed
the
07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier
branch
from
fd85cf5 to
93a5b76
Compare
Base automatically changed from
07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string
to
main
July 23, 2025 09:35
Contributor
Merge activity
|
graphite-app
bot
deleted the
07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
prev_constant_valuestores aOption<ConstantValue>, but we only useConstantValue::Number, so simplify it to store aOption<f64>