Skip to content

fix(transformer/typescript): incorrect evaluation of TemplateLiteral in enum#12456

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-23-fix_transformer_typescript_incorrect_evaluation_of_templateliteral_in_enum
Jul 23, 2025
Merged

fix(transformer/typescript): incorrect evaluation of TemplateLiteral in enum#12456
graphite-app[bot] merged 1 commit intomainfrom
07-23-fix_transformer_typescript_incorrect_evaluation_of_templateliteral_in_enum

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 23, 2025

@Dunqing Dunqing requested a review from overlookmotel as a code owner July 23, 2025 01:52
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Jul 23, 2025
Copy link
Member Author

Dunqing commented Jul 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Instrumentation Performance Report

Merging #12456 will not alter performance

Comparing 07-23-fix_transformer_typescript_incorrect_evaluation_of_templateliteral_in_enum (dcb245c) with main (0b17927)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (0a6da98) during the generation of this report, so 0b17927 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 23, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 07-23-fix_transformer_typescript_incorrect_evaluation_of_templateliteral_in_enum branch from fb1a5f7 to dcb245c Compare July 23, 2025 04:21
@graphite-app graphite-app bot merged commit dcb245c into main Jul 23, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-23-fix_transformer_typescript_incorrect_evaluation_of_templateliteral_in_enum branch July 23, 2025 04:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
graphite-app bot pushed a commit that referenced this pull request Jul 23, 2025
Follow-on after #12456. Improve the test case added in that PR to make sure values are indeed based on const evaluation of the `TemplateLiteral`s, not the enum member names, by making them different from each other.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Enums with computed values are transformed incorrectly

1 participant