Skip to content

test(transform/typescript): improve test case#12468

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-23-test_transform_typescript_improve_test_case
Jul 23, 2025
Merged

test(transform/typescript): improve test case#12468
graphite-app[bot] merged 1 commit intomainfrom
07-23-test_transform_typescript_improve_test_case

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 23, 2025

Follow-on after #12456. Improve the test case added in that PR to make sure values are indeed based on const evaluation of the TemplateLiterals, not the enum member names, by making them different from each other.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jul 23, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 23, 2025 10:16
@overlookmotel overlookmotel requested a review from Dunqing July 23, 2025 10:17
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
Copy link
Member

Boshen commented Jul 23, 2025

Merge activity

Follow-on after #12456. Improve the test case added in that PR to make sure values are indeed based on const evaluation of the `TemplateLiteral`s, not the enum member names, by making them different from each other.
@graphite-app graphite-app bot force-pushed the 07-23-test_transform_typescript_improve_test_case branch from 34f5b70 to 3fa0cff Compare July 23, 2025 10:26
@graphite-app graphite-app bot merged commit 3fa0cff into main Jul 23, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 07-23-test_transform_typescript_improve_test_case branch July 23, 2025 10:34
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants