Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
Contributor
Oxlint Ecosystem CI |
WalkthroughThe changes introduce version 0.16.9 across multiple components, including 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (9)
apps/oxlint/CHANGELOG.md(1 hunks)apps/oxlint/Cargo.toml(1 hunks)crates/oxc_language_server/CHANGELOG.md(1 hunks)crates/oxc_language_server/Cargo.toml(1 hunks)crates/oxc_linter/CHANGELOG.md(1 hunks)crates/oxc_linter/Cargo.toml(1 hunks)editors/vscode/CHANGELOG.md(1 hunks)editors/vscode/package.json(1 hunks)npm/oxlint/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: Benchmark (formatter)
- GitHub Check: Benchmark (codegen)
- GitHub Check: Test wasm32-wasip1-threads
- GitHub Check: Benchmark (minifier)
- GitHub Check: Test (macos-latest)
- GitHub Check: Benchmark (semantic)
- GitHub Check: Test NAPI
- GitHub Check: Benchmark (isolated_declarations)
- GitHub Check: Test (ubuntu-latest)
- GitHub Check: Benchmark (transformer)
- GitHub Check: Benchmark (parser)
- GitHub Check: Clippy
- GitHub Check: Benchmark (lexer)
- GitHub Check: Test
- GitHub Check: Build Linter Benchmark
- GitHub Check: Conformance
🔇 Additional comments (18)
apps/oxlint/Cargo.toml (1)
3-3: Approved: Version bump to v0.16.9
The package version has been correctly updated to align with the new release.crates/oxc_linter/Cargo.toml (1)
3-3: Approved: Version bump to v0.16.9
Consistent with the coordinated release across theoxc_lintercrate.crates/oxc_language_server/Cargo.toml (1)
3-3: Approved: Version bump to v0.16.9
Matches the release version used by related crates and the VSCode extension.npm/oxlint/package.json (1)
3-3: Approved: Package version updated to 0.16.9
Ensures the npm package reflects the latest release.editors/vscode/package.json (1)
5-5: Approved: Extension version updated to 0.16.9
Keeps the VSCode extension metadata in sync with the core packages.apps/oxlint/CHANGELOG.md (3)
7-7: Changelog: Version header updated correctly
The new version0.16.9and date2025-05-02align with the coordinated release.
11-13: Changelog: Features documented accurately
The two new rules (react/forward_ref_uses_ref,unicorn/consistent-assert) are correctly listed under Features.
16-16: Changelog: Bug fix entry is consistent
Movingconsistent-assertto thepedanticcategory is properly captured under Bug Fixes.editors/vscode/CHANGELOG.md (4)
7-7: Changelog: Version header updated correctly
The VSCode extension entry for0.16.9dated2025-05-02is in place.
11-11: Changelog: Bug Fix documented
Activation on Astro files (#10725) is correctly captured under Bug Fixes.
15-15: Changelog: Documentation update noted
Clarification thatoxc.flagsare unrelated tooxlintis captured under Documentation.
19-19: Changelog: Testing entry captured
The test for nested config severity (#10697) is appropriately listed under Testing.crates/oxc_language_server/CHANGELOG.md (2)
7-7: Changelog: Version header updated correctly
The language server changelog includes the0.16.9header with the correct release date.
16-21: Changelog: Testing entries are complete
The refactor and new tests (WorkspaceWorker,init_nested_configs, slow test fixes, snapshot updates) are all listed under Testing.crates/oxc_linter/CHANGELOG.md (4)
7-7: Changelog: Version header updated correctly
Theoxc_lintercrate version bump to0.16.9is correctly documented with2025-05-02.
9-12: Changelog: Breaking changes documented
The two breaking changes (AstBuilder lifetime, CodeGenerator alias removal) are clearly marked.
15-24: Changelog: Features documented comprehensively
All new lint rules and autofixers are accurately listed under Features.
44-44: Changelog: Performance improvement noted
Usingformat_compact_str!is appropriately documented under Performance.
Comment on lines
+11
to
+12
| - 46665bd langage_server: Fix initialize nested configs (#10698) (Sysix) | ||
| - 98bcd5f lsp: Incorrect quick fix offset in vue files (#10742) (camc314) |
There was a problem hiding this comment.
Typo in component prefix
The entry uses langage_server instead of language_server.
Apply this diff:
- 46665bd langage_server: Fix initialize nested configs (#10698) (Sysix)
+ 46665bd language_server: Fix initialize nested configs (#10698) (Sysix)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - 46665bd langage_server: Fix initialize nested configs (#10698) (Sysix) | |
| - 98bcd5f lsp: Incorrect quick fix offset in vue files (#10742) (camc314) | |
| - 46665bd language_server: Fix initialize nested configs (#10698) (Sysix) | |
| - 98bcd5f lsp: Incorrect quick fix offset in vue files (#10742) (camc314) |
🤖 Prompt for AI Agents (early access)
In crates/oxc_language_server/CHANGELOG.md around lines 11 to 12, correct the typo in the component prefix by changing "langage_server" to "language_server" in the changelog entry to ensure accurate naming.
Comment on lines
+27
to
+41
| - b38338a linter: Make require post message target origin a fixer a suggestion (#10754) (camc314) | ||
| - 48c542d linter: Skip linting vue <script> where `lang` is not js / ts (#10740) (Boshen) | ||
| - c9575f6 linter: Fix false positive in react/exhaustive deps (#10727) (camc314) | ||
| - d8d8f64 linter: Shorten span of promise/prefer-await-to-then (#10717) (camc314) | ||
| - a88e349 linter: Mark `isNan` and `isFinite` as dangerous fixes in `unicorn/prefer-number-properties` (#10706) (Sysix) | ||
| - f4ab05f linter: Panic in unicorn/no-useless-spread (#10715) (camc314) | ||
| - 06f1717 linter: False positive in no unused vars when importing value used as type (#10690) (camc314) | ||
| - 746b318 linter: False positive in typescript/explicit-function-return-type with `satisfies` (#10668) (camc314) | ||
| - cce1043 linter: False positive in typescript/explicit-function-return-type (#10667) (camc314) | ||
| - c89da93 linter: False positive in eslint/curly on windows (#10671) (camc314) | ||
| - 374e19e linter: False positive in react/jsx-curly-brace-presence (#10663) (camc314) | ||
| - e7c2b32 linter: Move `consistent-assert` to `pedantic` (#10665) (camc314) | ||
| - 344ef88 linter: False positive in `eslint/no-unused-vars` when calling inside sequence expression (#10646) (Ulrich Stark) | ||
| - 98bcd5f lsp: Incorrect quick fix offset in vue files (#10742) (camc314) | ||
|
|
There was a problem hiding this comment.
Inconsistent Bug Fix entry: Remove LSP-specific fix
The entry 98bcd5f lsp: Incorrect quick fix offset in vue files (#10742) pertains to the language server, not the linter crate.
Please remove or relocate this line to crates/oxc_language_server/CHANGELOG.md.
🤖 Prompt for AI Agents (early access)
In crates/oxc_linter/CHANGELOG.md around lines 27 to 41, the changelog entry "98bcd5f lsp: Incorrect quick fix offset in vue files (#10742)" is incorrectly placed as it relates to the language server, not the linter crate. Remove this line from this file and add it appropriately to crates/oxc_language_server/CHANGELOG.md to maintain accurate changelog categorization.
CodSpeed Instrumentation Performance ReportMerging #10765 will not alter performanceComparing Summary
|
Member
Member
|
The error message |
Contributor
panic``` thread '' panicked at crates/oxc_span/src/span.rs:394:21: byte index 2252 is out of bounds of `` stack backtrace: 0: 0x102df425c - ::fmt::h217270392019d164 1: 0x102e10af0 - core::fmt::write::he22fcab56bd3ec61 2: 0x102df1008 - std::io::Write::write_fmt::hb32eaafcfd249a19 3: 0x102df4110 - std::sys::backtrace::BacktraceLock::print::h115149c0b879e5c3 4: 0x102df4ff4 - std::panicking::default_hook::{{closure}}::h5c3a234feebd11a5 5: 0x102df4e30 - std::panicking::default_hook::ha0b223ccc4379930 6: 0x102df5b24 - std::panicking::rust_panic_with_hook::h203f96c93e7ac62d 7: 0x102df56f0 - std::panicking::begin_panic_handler::{{closure}}::hcc8f653f753c0254 8: 0x102df4710 - std::sys::backtrace::__rust_end_short_backtrace::h911de07218b69a6c 9: 0x102df53a8 - _rust_begin_unwind 10: 0x102e565ac - core::panicking::panic_fmt::h6a4014bec58fba4f 11: 0x102e14ec0 - core::str::slice_error_fail_rt::hd494714b9640772b 12: 0x102e56ae8 - core::str::slice_error_fail::h8b847e853482f553 13: 0x102dc8f24 - core::str::traits:: for core::ops::range::Range>::index::hf103bff220f087eb 14: 0x102dc8f60 - core::str::traits:: for str>::index::h633e8cf5277a944c 15: 0x102cdfb50 - oxc_span::span::Span::source_text::hf27af05aedeca32b 16: 0x102c1f8e4 - oxc_ast::ast_impl::literal::::source_text::hca09dfb087824ed8 17: 0x102b4fe1c - ::gen::heaac161671f88070 18: 0x102b58608 - oxc_codegen::gen::Gen::print::hb69db04ae20c110b 19: 0x102b476e4 - ::gen_expr::ha6c3044f09ff3c2d 20: 0x102b64184 - oxc_codegen::gen::GenExpr::print_expr::h9f8c702711f98ddd 21: 0x102b48224 - ::gen::hd6f7d43eaf909869 22: 0x102b63b6c - oxc_codegen::gen::Gen::print::h29bbdd9173178286 23: 0x102b53484 - oxc_codegen::Codegen::print_list::he985dca9186b1007 24: 0x102b5a24c - ::gen_expr::{{closure}}::h5b144c271355b69e 25: 0x102b520c0 - oxc_codegen::Codegen::wrap::he94220179cd5c7cc 26: 0x102b48190 - ::gen_expr::h90f4fc752e1ac07f 27: 0x102b64210 - oxc_codegen::gen::GenExpr::print_expr::hbf789afe13eea2f4 28: 0x102b47828 - ::gen_expr::ha6c3044f09ff3c2d 29: 0x102b64184 - oxc_codegen::gen::GenExpr::print_expr::h9f8c702711f98ddd 30: 0x1025c219c - oxc_codegen::Codegen::print_expression::h8d980e8befd6a7fc 31: 0x10244368c - oxc_linter::rules::unicorn::prefer_spread::report_with_spread_fixer::{{closure}}::h8dc5bbb9d393a038 32: 0x10281070c - oxc_linter::context::LintContext::diagnostic_with_fix_of_kind::h4c27284b26c35bb9 33: 0x1027f3b58 - oxc_linter::context::LintContext::diagnostic_with_fix::h97d0bc7a50ef425f 34: 0x1025ed2bc - oxc_linter::rules::unicorn::prefer_spread::report_with_spread_fixer::h1c68d4a7a3cd2af8 35: 0x1025ececc - oxc_linter::rules::unicorn::prefer_spread::check_unicorn_prefer_spread::h77d0420d3dd5bf2d 36: 0x1025ec954 - ::run::hf7b0910289cced29 37: 0x1027b488c - oxc_linter::rules::RuleEnum::run::h7673f95b1eec5c5f 38: 0x1024c077c - oxc_linter::Linter::run::h4ef85e13935e76dd 39: 0x1026f1f74 - oxc_linter::service::runtime::Runtime::run::{{closure}}::{{closure}}::{{closure}}::hc4134d65aac18d90 40: 0x1026f2a14 - oxc_linter::service::runtime::ModuleContent::with_dependent_mut::h82ffc7325a8710ec 41: 0x1026f19f0 - oxc_linter::service::runtime::Runtime::run::{{closure}}::{{closure}}::h94d4527f9c3406a3 42: 0x1026f0ecc - oxc_linter::service::runtime::Runtime::resolve_modules::{{closure}}::h93cca1e9f75fd620 43: 0x1026ef580 - core::ops::function::impls:: for &F>::call_mut::hdd7dd17fe03e5490 44: 0x10285fac8 - core::iter::traits::iterator::Iterator::for_each::call::{{closure}}::h4c7c48b5ba05af8a 45: 0x1025432fc - core::iter::adapters::map::map_fold::{{closure}}::hb07b0e09e1de01e1 46: 0x10242bb10 - as core::iter::traits::iterator::Iterator>::fold::h5bf0adde7d61cb5f 47: 0x1025391dc - as core::iter::traits::iterator::Iterator>::fold::hcb887d7827f39d78 48: 0x10253e4cc - core::iter::traits::iterator::Iterator::for_each::he588a763e2977758 49: 0x102742d90 - as rayon::iter::plumbing::Folder>::consume_iter::h654039774732d7e9 50: 0x1025bc590 - as rayon::iter::plumbing::Folder>::consume_iter::h82e2d493d51bbb49 51: 0x102524240 - rayon::iter::plumbing::Producer::fold_with::hde1481d1db3dd643 52: 0x1027e8b8c - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 53: 0x1027e913c - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hf2229acf4da51ec0 54: 0x10266eee8 - rayon_core::join::join_context::call_b::{{closure}}::h74811ac01be566bd 55: 0x1027804c4 - rayon_core::job::StackJob::run_inline::h5827e2c8d368279b 56: 0x10266e140 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 57: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 58: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 59: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 60: 0x1027e9050 - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hde2c29424f04bca4 61: 0x10266ec90 - rayon_core::join::join_context::call_a::{{closure}}::hc10570a6cfe11ac1 62: 0x10266f3dc - as core::ops::function::FnOnce<()>>::call_once::hc89b0581a6df5624 63: 0x1025bd1a0 - std::panicking::try::do_call::h6513939119cea940 64: 0x102494fe0 - ___rust_try 65: 0x102494f80 - std::panic::catch_unwind::hff4c9b6519ccf9c0 66: 0x10251b72c - rayon_core::unwind::halt_unwinding::h084c92c52ac77648 67: 0x10266df78 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 68: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 69: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 70: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 71: 0x1027e9050 - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hde2c29424f04bca4 72: 0x10266ec90 - rayon_core::join::join_context::call_a::{{closure}}::hc10570a6cfe11ac1 73: 0x10266f3dc - as core::ops::function::FnOnce<()>>::call_once::hc89b0581a6df5624 74: 0x1025bd1a0 - std::panicking::try::do_call::h6513939119cea940 75: 0x102494fe0 - ___rust_try 76: 0x102494f80 - std::panic::catch_unwind::hff4c9b6519ccf9c0 77: 0x10251b72c - rayon_core::unwind::halt_unwinding::h084c92c52ac77648 78: 0x10266df78 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 79: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 80: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 81: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 82: 0x1027e913c - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hf2229acf4da51ec0 83: 0x10266eee8 - rayon_core::join::join_context::call_b::{{closure}}::h74811ac01be566bd 84: 0x1027804c4 - rayon_core::job::StackJob::run_inline::h5827e2c8d368279b 85: 0x10266e140 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 86: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 87: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 88: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 89: 0x1027e9050 - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hde2c29424f04bca4 90: 0x10266ec90 - rayon_core::join::join_context::call_a::{{closure}}::hc10570a6cfe11ac1 91: 0x10266f3dc - as core::ops::function::FnOnce<()>>::call_once::hc89b0581a6df5624 92: 0x1025bd1a0 - std::panicking::try::do_call::h6513939119cea940 93: 0x102494fe0 - ___rust_try 94: 0x102494f80 - std::panic::catch_unwind::hff4c9b6519ccf9c0 95: 0x10251b72c - rayon_core::unwind::halt_unwinding::h084c92c52ac77648 96: 0x10266df78 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 97: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 98: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 99: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 100: 0x1027e913c - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hf2229acf4da51ec0 101: 0x10266eee8 - rayon_core::join::join_context::call_b::{{closure}}::h74811ac01be566bd 102: 0x102780044 - rayon_core::job::JobResult::call::{{closure}}::hde4fd8018bd0e049 103: 0x10266f338 - as core::ops::function::FnOnce<()>>::call_once::h7e2d18eac616d856 104: 0x1025bd0a0 - std::panicking::try::do_call::h3f418470cf2914eb 105: 0x102494fe0 - ___rust_try 106: 0x102494afc - std::panic::catch_unwind::h82c69222caa466ee 107: 0x10251ba98 - rayon_core::unwind::halt_unwinding::hf5de06916f727dc3 108: 0x10277faac - rayon_core::job::JobResult::call::h763918f09de34750 109: 0x1027823d0 - as rayon_core::job::Job>::execute::ha3a8f6f0a321f1f6 110: 0x102d124bc - rayon_core::job::JobRef::execute::he81955004df86cc5 111: 0x102d0a16c - rayon_core::registry::WorkerThread::execute::h14d00818df261412 112: 0x102e5241c - rayon_core::registry::WorkerThread::wait_until_cold::h5612d3606dc2272d 113: 0x102d09f40 - rayon_core::registry::WorkerThread::wait_until::h82de6f62de63c364 114: 0x10266e0d0 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 115: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 116: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 117: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 118: 0x1027e913c - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hf2229acf4da51ec0 119: 0x10266eee8 - rayon_core::join::join_context::call_b::{{closure}}::h74811ac01be566bd 120: 0x1027804c4 - rayon_core::job::StackJob::run_inline::h5827e2c8d368279b 121: 0x10266e140 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 122: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 123: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 124: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 125: 0x1027e913c - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hf2229acf4da51ec0 126: 0x10266eee8 - rayon_core::join::join_context::call_b::{{closure}}::h74811ac01be566bd 127: 0x1027804c4 - rayon_core::job::StackJob::run_inline::h5827e2c8d368279b 128: 0x10266e140 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 129: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 130: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 131: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 132: 0x1027e9050 - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hde2c29424f04bca4 133: 0x10266ec90 - rayon_core::join::join_context::call_a::{{closure}}::hc10570a6cfe11ac1 134: 0x10266f3dc - as core::ops::function::FnOnce<()>>::call_once::hc89b0581a6df5624 135: 0x1025bd1a0 - std::panicking::try::do_call::h6513939119cea940 136: 0x102494fe0 - ___rust_try 137: 0x102494f80 - std::panic::catch_unwind::hff4c9b6519ccf9c0 138: 0x10251b72c - rayon_core::unwind::halt_unwinding::h084c92c52ac77648 139: 0x10266df78 - rayon_core::join::join_context::{{closure}}::h0c719dc5d176a515 140: 0x1026ac680 - rayon_core::registry::in_worker::hab538c369149797c 141: 0x10266dde4 - rayon_core::join::join_context::hec79260b50cf0690 142: 0x1027e8ce4 - rayon::iter::plumbing::bridge_producer_consumer::helper::hceadda49b2df56ba 143: 0x1027e913c - rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}::hf2229acf4da51ec0 144: 0x10266eee8 - rayon_core::join::join_context::call_b::{{closure}}::h74811ac01be566bd 145: 0x102780044 - rayon_core::job::JobResult::call::{{closure}}::hde4fd8018bd0e049 146: 0x10266f338 - as core::ops::function::FnOnce<()>>::call_once::h7e2d18eac616d856 147: 0x1025bd0a0 - std::panicking::try::do_call::h3f418470cf2914eb 148: 0x102494fe0 - ___rust_try 149: 0x102494afc - std::panic::catch_unwind::h82c69222caa466ee 150: 0x10251ba98 - rayon_core::unwind::halt_unwinding::hf5de06916f727dc3 151: 0x10277faac - rayon_core::job::JobResult::call::h763918f09de34750 152: 0x1027823d0 - as rayon_core::job::Job>::execute::ha3a8f6f0a321f1f6 153: 0x102d124bc - rayon_core::job::JobRef::execute::he81955004df86cc5 154: 0x102d0a16c - rayon_core::registry::WorkerThread::execute::h14d00818df261412 155: 0x102e5241c - rayon_core::registry::WorkerThread::wait_until_cold::h5612d3606dc2272d 156: 0x102d09efc - rayon_core::registry::WorkerThread::wait_until::h64517455be2160cb 157: 0x102d0a004 - rayon_core::registry::WorkerThread::wait_until_out_of_work::h2045017d4fe71dcb 158: 0x102d0a460 - rayon_core::registry::main_loop::h1cb97efbd1706fdf 159: 0x102d07b3c - rayon_core::registry::ThreadBuilder::run::ha4c74812441df050 160: 0x102d07e64 - ::spawn::{{closure}}::hc267229c70195914 161: 0x102d15b5c - std::sys::backtrace::__rust_begin_short_backtrace::h68e2175d0124c65d 162: 0x102d144b4 - std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}::h6182d9f274c37cae 163: 0x102d130b0 - as core::ops::function::FnOnce<()>>::call_once::hba39a33339bb236a 164: 0x102d18014 - std::panicking::try::do_call::h27a594c700a05725 165: 0x102d15354 - ___rust_try 166: 0x102d141f8 - std::thread::Builder::spawn_unchecked_::{{closure}}::haff00ed6d36f64d0 167: 0x102d0cbfc - core::ops::function::FnOnce::call_once{{vtable.shim}}::hbff7e6164644c7fa 168: 0x102df81e4 - std::sys::pal::unix::thread::Thread::new::thread_start::h6d53b1b0c047a3b9 169: 0x19ace9c0c - __pthread_cond_wait ```codegen is panic-ing inside a fixer when code-genning regex lit. |
Contributor
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 3, 2025
fixes the panic in #10765 by providing the source text of the program to the code generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[0.16.9] - 2025-05-02
Features
Bug Fixes
langis not js / ts (fix(linter): skip linting vue <script> wherelangis not js / ts #10740) (Boshen)isNanandisFiniteas dangerous fixes inunicorn/prefer-number-properties(fix(linter): markisNanandisFiniteas dangerous fixes inunicorn/prefer-number-properties#10706) (Sysix)satisfies(fix(linter): false positive in typescript/explicit-function-return-type withsatisfies#10668) (camc314)consistent-asserttopedantic(fix(linter): moveconsistent-asserttopedantic#10665) (camc314)eslint/no-unused-varswhen calling inside sequence expression (fix(linter): false positive ineslint/no-unused-varswhen calling inside sequence expression #10646) (Ulrich Stark)Performance
format_compact_str!(perf(transformer, linter): useformat_compact_str!#10753) (overlookmotel)Documentation
oxc.flagsare not related tooxlint(docs(editor):oxc.flagsare not related tooxlint#10645) (Sysix)Refactor
Testing
init_nested_configs(test(language_server): add test forinit_nested_configs#10728) (Sysix)