Skip to content

feat(linter/no-new-wrapper): implement auto-fixer#10680

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/04-28-feat_linter/no-new-wrapper_implement_auto-fixer
Apr 28, 2025
Merged

feat(linter/no-new-wrapper): implement auto-fixer#10680
graphite-app[bot] merged 1 commit intomainfrom
don/04-28-feat_linter/no-new-wrapper_implement_auto-fixer

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Apr 28, 2025

  • Implement auto fixer for eslint/no-new-wrapper
  • Report new Symbol(expr) as a violation. Diagnostics for this case warn that Symbol is not a constructor.
  • Limit length of report spans to 24, falling back to underlying only new Builtin

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Apr 28, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DonIsaac DonIsaac marked this pull request as ready for review April 28, 2025 18:08
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10680 will not alter performance

Comparing don/04-28-feat_linter/no-new-wrapper_implement_auto-fixer (432cd77) with main (c89da93)

Summary

✅ 36 untouched benchmarks

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
Copy link
Contributor

camc314 commented Apr 28, 2025

Merge activity

- Implement auto fixer for `eslint/no-new-wrapper`
- Report `new Symbol(expr)` as a violation. Diagnostics for this case warn that `Symbol` is not a constructor.
- Limit length of report spans to 24, falling back to underlying only `new Builtin`
@graphite-app graphite-app bot force-pushed the don/04-28-feat_linter/no-new-wrapper_implement_auto-fixer branch from c0a3820 to 432cd77 Compare April 28, 2025 18:42
@graphite-app graphite-app bot merged commit 432cd77 into main Apr 28, 2025
23 checks passed
@graphite-app graphite-app bot deleted the don/04-28-feat_linter/no-new-wrapper_implement_auto-fixer branch April 28, 2025 18:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants