Skip to content

fix(linter): false positive in no unused vars when importing value used as type#10690

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/04-29-fix_linter_false_positive_in_no_unused_vars_when_importing_value_used_as_type
Apr 29, 2025
Merged

fix(linter): false positive in no unused vars when importing value used as type#10690
graphite-app[bot] merged 1 commit intomainfrom
c/04-29-fix_linter_false_positive_in_no_unused_vars_when_importing_value_used_as_type

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Apr 29, 2025

I accidently copied a pass test case to the fail array.

import { foo } from '';

export type Foo = typeof foo;

is allowed

Copy link
Contributor Author

camc314 commented Apr 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Apr 29, 2025
@camc314 camc314 marked this pull request as ready for review April 29, 2025 08:07
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 29, 2025

CodSpeed Instrumentation Performance Report

Merging #10690 will not alter performance

Comparing c/04-29-fix_linter_false_positive_in_no_unused_vars_when_importing_value_used_as_type (06f1717) with main (ea784f5)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
Copy link
Member

Boshen commented Apr 29, 2025

Merge activity

…ed as type (#10690)

I accidently copied a pass test case to the fail array.

```
import { foo } from '';

export type Foo = typeof foo;
```
 is allowed
@graphite-app graphite-app bot force-pushed the c/04-29-fix_linter_false_positive_in_no_unused_vars_when_importing_value_used_as_type branch from df52761 to 06f1717 Compare April 29, 2025 10:07
@graphite-app graphite-app bot merged commit 06f1717 into main Apr 29, 2025
23 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@graphite-app graphite-app bot deleted the c/04-29-fix_linter_false_positive_in_no_unused_vars_when_importing_value_used_as_type branch April 29, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants