feat(semantic)!: do not need to return old name in Scoping::set_symbol_name

[Dunqing]

The only usage that needs the old name has been refactored in #10612. Remove the returning old name logic, then the implementation is simpler.

[Dunqing]

• feat(semantic)!: do not need to return old name in Scoping::set_symbol_name #10613 👈 (View in Graphite)
• perf(semantic): optimize Scoping::rename_symbol method #10612
• refactor(traverse, semantic): move rename_symbol from TraverseScoping to Scoping #10611
• refactor(traverse): take &str instead of CompactStr in TraverseScoping::rename_symbol #10610
• perf(traverse): use ArenaString instead CompactString to store UID name #10562 : 1 other dependent PR (#9881 )
• refactor(allocator)!: return &'alloc str rather than &'alloc mut str in Allocator::alloc_str method #10564
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10613 will not alter performance

_{Comparing 04-25-feat_semantic_do_not_need_to_return_old_name_in_set_symbol_name (624d3f1) with main (075d4b5)}

Summary

✅ 36 untouched benchmarks

[Boshen]

Merge activity

• Apr 26, 11:07 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 26, 11:38 PM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 27, 3:50 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #10610.