perf(traverse): use ArenaString instead CompactString to store UID name

[Dunqing]

close: #10545

[Dunqing]

• perf(traverse): use ArenaString instead CompactString to store UID name #10562 : 2 dependent PRs (#9881 , #10610 ) 👈 (View in Graphite)
• refactor(allocator)!: return &'alloc str rather than &'alloc mut str in Allocator::alloc_str method #10564
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10562 will improve performances by 6.3%

_{Comparing 04-23-perf_traverse_use_arenastring_instead_compactstring_to_stote_uid_name (bdcbeb4) with main (f89aec6)}

Summary

⚡ 2 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	transformer[antd.js]	49.8 ms	47.4 ms	+4.97%
⚡	transformer[cal.com.tsx]	32.9 ms	31 ms	+6.3%

[overlookmotel]

Holy smokes!

[Dunqing]

I found another possible improvement. Since generating UID name has used ArenaString, we can add a generate_uid_name_arena_string method to take ArenaString rather than &str because we still have a few places that use CompactString or format!() to construct a temporary name to pass in the generate_uid_name method. If we have this method, then we can use ArenaString to construct and pass in to get a UID name without double allocation.

oxc/crates/oxc_transformer/src/es2022/class_properties/class.rs

Lines 115 to 125 in 7e71282

	let name = match method.kind {
	MethodDefinitionKind::Method => ident.name.as_str(),
	MethodDefinitionKind::Get => &format!("get_{}", ident.name),
	MethodDefinitionKind::Set => &format!("set_{}", ident.name),
	MethodDefinitionKind::Constructor => unreachable!(),
	};
	let binding = ctx.generate_uid(
	name,
	ctx.current_block_scope_id(),
	SymbolFlags::Function,
	);

oxc/crates/oxc_transformer/src/es2022/class_properties/class.rs

Lines 115 to 125 in 7e71282

	let name = match method.kind {
	MethodDefinitionKind::Method => ident.name.as_str(),
	MethodDefinitionKind::Get => &format!("get_{}", ident.name),
	MethodDefinitionKind::Set => &format!("set_{}", ident.name),
	MethodDefinitionKind::Constructor => unreachable!(),
	};
	let binding = ctx.generate_uid(
	name,
	ctx.current_block_scope_id(),
	SymbolFlags::Function,
	);

[Boshen]

Merge activity

• Apr 26, 10:38 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 26, 10:38 PM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 26, 10:47 PM EDT: Merged by the Graphite merge queue.