Skip to content

refactor(traverse, semantic): move rename_symbol from TraverseScoping to Scoping#10611

Merged
Boshen merged 1 commit intomainfrom
04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping
Apr 27, 2025
Merged

refactor(traverse, semantic): move rename_symbol from TraverseScoping to Scoping#10611
Boshen merged 1 commit intomainfrom
04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 25, 2025

Part of oxc-project/backlog#163

Prepare #10612. I just found that this method has a to_string allocation that can be avoided. However, it needs to combine set_symbol_name and rename_binding, so move to Semantic.

Copy link
Member Author

Dunqing commented Apr 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 25, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Instrumentation Performance Report

Merging #10611 will not alter performance

Comparing 04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping (c82ef6b) with main (bb522fa)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from 18dc313 to 4a04b8a Compare April 25, 2025 02:52
@Dunqing Dunqing force-pushed the 04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping branch from 43a0e3a to 1578ef4 Compare April 25, 2025 02:52
@Dunqing Dunqing marked this pull request as ready for review April 25, 2025 02:56
@graphite-app graphite-app bot force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch 2 times, most recently from ae72876 to c522027 Compare April 27, 2025 02:50
@graphite-app graphite-app bot force-pushed the 04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping branch from 1578ef4 to 0013165 Compare April 27, 2025 02:50
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 27, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 27, 2025

Merge activity

  • Apr 27, 3:16 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 27, 3:32 AM UTC: graphite-app added this pull request to the Graphite merge queue.
  • Apr 27, 3:50 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #10610.

@Dunqing Dunqing force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from c522027 to 62fa7de Compare April 27, 2025 03:23
@Dunqing Dunqing force-pushed the 04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping branch from 0013165 to e0bab74 Compare April 27, 2025 03:23
@graphite-app graphite-app bot changed the base branch from 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol to graphite-base/10611 April 27, 2025 03:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 27, 2025
@Boshen Boshen force-pushed the 04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping branch from e0bab74 to e76a059 Compare April 27, 2025 04:50
@Boshen Boshen force-pushed the graphite-base/10611 branch from 62fa7de to dddfdb4 Compare April 27, 2025 04:50
@Boshen Boshen changed the base branch from graphite-base/10611 to 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol April 27, 2025 04:50
@Boshen Boshen force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from dddfdb4 to b31ab87 Compare April 27, 2025 05:10
@Boshen Boshen force-pushed the 04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping branch from e76a059 to ac31f1f Compare April 27, 2025 05:10
Base automatically changed from 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol to main April 27, 2025 05:21
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 27, 2025
@Boshen Boshen force-pushed the 04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping branch from ac31f1f to c82ef6b Compare April 27, 2025 11:57
@Boshen Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Apr 27, 2025
@Boshen Boshen merged commit f35efd3 into main Apr 27, 2025
27 checks passed
@Boshen Boshen deleted the 04-25-refactor_traverse_semantic_move_rename_symbol_from_traversescoping_to_scoping branch April 27, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants