refactor(allocator)!: return &'alloc str rather than &'alloc mut str in Allocator::alloc_str method#10564
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 23, 2025
Conversation
Dunqing
changed the title
&'alloc str rather than &'alloc mut str in Allocator::alloc_str method&'alloc str rather than &'alloc mut str in Allocator::alloc_str method
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10564 will not alter performanceComparing Summary
|
overlookmotel
approved these changes
Apr 23, 2025
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
I left it the same as Bumpalo's alloc_str method on the grounds that we might want a &mut str for something. But you're right - we have no obvious use cases for that.
Member
Merge activity
|
…tr` in `Allocator::alloc_str` method (#10564) No reason we return a `mut str` in this method.
graphite-app
bot
force-pushed
the
04-23-refactor_allocator_return_alloc_str_rather_than_alloc_mut_str_in_allocator_alloc_str_method
branch
from
d7962e9 to
fb829d9
Compare
graphite-app
bot
deleted the
04-23-refactor_allocator_return_alloc_str_rather_than_alloc_mut_str_in_allocator_alloc_str_method
branch
This was referenced Apr 25, 2025
Closed
perf(allocator/vec2): replace
self.reserve(1) calls with self.grow_one() for better efficiency
#9856
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No reason we return a
mut strin this method.