Skip to content

feat(semantic)!: do not need to return old name in Scoping::set_symbol_name #10613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Apr 27, 2025
Merged

feat(semantic)!: do not need to return old name in Scoping::set_symbol_name #10613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions crates/oxc_semantic/src/scoping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,10 @@ impl Scoping {
///
/// Returns the old name.
#[inline]
pub fn set_symbol_name(&mut self, symbol_id: SymbolId, name: &str) -> &str {
self.cell
.with_dependent_mut(|allocator, cell| {
mem::replace(
&mut cell.symbol_names[symbol_id.index()],
Atom::from_in(name, allocator),
)
})
.as_str()
pub fn set_symbol_name(&mut self, symbol_id: SymbolId, name: &str) {
self.cell.with_dependent_mut(|allocator, cell| {
cell.symbol_names[symbol_id.index()] = Atom::from_in(name, allocator);
});
}

/// Get the [`SymbolFlags`] for a symbol, which describe how the symbol is declared.
Expand Down Expand Up @@ -805,7 +800,7 @@ impl Scoping {
/// Panics in debug mode if either of the above are not satisfied.
pub fn rename_symbol(&mut self, symbol_id: SymbolId, scope_id: ScopeId, new_name: &str) {
self.cell.with_dependent_mut(|allocator, cell| {
// Rename symbol name, same as `Self::set_symbol_name`
// Rename symbol name.
let old_name = mem::replace(
&mut cell.symbol_names[symbol_id.index()],
Atom::from_in(new_name, allocator),
Expand Down
Loading