Skip to content

perf(traverse): get_unique_name use String::set_len#10758

Closed
overlookmotel wants to merge 1 commit into05-01-feat_allocator_add_string_set_len_methodfrom
05-01-perf_traverse_get_unique_name_use_string_set_len_
Closed

perf(traverse): get_unique_name use String::set_len#10758
overlookmotel wants to merge 1 commit into05-01-feat_allocator_add_string_set_len_methodfrom
05-01-perf_traverse_get_unique_name_use_string_set_len_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 1, 2025

Follow-on after #10562. We had to remove an optimization due to lack of set_len method on String. #10757 adds that method, so now we can use it.

Copy link
Member Author

overlookmotel commented May 1, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label May 1, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 1, 2025 16:50
@codspeed-hq
Copy link

codspeed-hq bot commented May 1, 2025

CodSpeed Instrumentation Performance Report

Merging #10758 will not alter performance

Comparing 05-01-perf_traverse_get_unique_name_use_string_set_len_ (2123607) with 05-01-feat_allocator_add_string_set_len_method (1b4d9ff)

Summary

✅ 36 untouched benchmarks

@overlookmotel
Copy link
Member Author

Superceded by #10759.

@Boshen Boshen deleted the 05-01-perf_traverse_get_unique_name_use_string_set_len_ branch August 30, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant