Support an aws installer CI job #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
smarterclayton
force-pushed
the
aws-installer
branch
from
71638bf to
51df634
Compare
Contributor
|
@smarterclayton: Updated the following 2 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Sep 18, 2018
…ontinue-on-error Taking advantage of openshift/installer@23915f2e (installer/*: Add --continue-on-error to destroy workflow, 2018-09-16, openshift/installer#252) so we can reap at least most of our resources even if the cluster doesn't come up enough for the machine API operator to be able to destroy workers. With various stages of cluster health: 1. Cluster never comes up at all. 2. Cluster healthy enough to create workers. 3. Cluster healthy enough to destroy workers. we're only worried about leakage in the space between 2 and 3. Hopefully there isn't any space there, but without this commit we're currently leaking resources from 1 as well. The two-part destroy attempts are originally from 51df634 (Support an aws installer CI job, 2018-06-07, openshift#928), although there's not much to motivate them there. With --continue-on-error destruction, we're already trying pretty hard to clean everything up. So excepting brief network hiccups and such, I think a single pass is sufficient. And we'll want a better backstop to catch any resources that leak through (e.g. orphaned workers), so I'm dropping the retry here.
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Feb 27, 2019
This image has been unused since the e2e template landed in 51df634 (Support an aws installer CI job, 2018-06-07, openshift#928) and since the Ansible template landed in c35a30a (Add a profile openshift-ansible custom AWS provisioner, 2018-08-30, openshift#1367). Also remove the duplicated entry from the src template which landed in aed67fc (Source installer tests should have access to IMAGE_FORMAT, 2019-01-25, openshift#2701).
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jan 14, 2022
We've had these in the steps since the steps were created in 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). It seems to have originally descended from 51df634 (Support an aws installer CI job, 2018-06-07, openshift#928), where it was used to copy 'oc' from the test container into the teardown container. But since the gather commands are run directly from the 'cli' image, there's no need for that sort of hoop-jumping.
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
Use a better value for $PS4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.