Openshift ansible: add runs on AWS CI #1367
Conversation
openshift-ci-robot
added
the
size/XL
vrutkovs
force-pushed
the
openshift-ansible-aws-ci
branch
from
f5794e7 to
95791dd
Compare
vrutkovs
force-pushed
the
openshift-ansible-aws-ci
branch
from
95791dd to
ac83ec3
Compare
| cd /usr/share/ansible/openshift-ansible | ||
| ansible-playbook -vv \ | ||
| -i test/ci/inventory \ | ||
| test/ci/launch.yml | tee -a /tmp/artifacts/ansible.log |
There was a problem hiding this comment.
This will cause the logs to be archived even if the container exits successfully.
If you want to log only in case of failure, just send it to stdout/err.
There was a problem hiding this comment.
We do want that, but I'll remove that until openshift/ci-operator#118 is implemented
There was a problem hiding this comment.
Oh, right, it's that case.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbguimaraes, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@vrutkovs: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -0,0 +1,313 @@ | |||
| kind: Template | |||
There was a problem hiding this comment.
This is not correct. You should have been using cluster-launch-e2e which is already configured against AWS - anything "special" to AWS should have been in an if block, or better, placed within the entry point.
Please open a follow up and converge this - this file should not exist.
There was a problem hiding this comment.
This PR has a confusing title, sorry. Openshift ansible team needs a bare-metal-like tests, which use prerequisites and deploy_cluster playbooks with openshift-ansible-specific settings - e.g. Atomic host etc. This is why there is a new template - so that openshift-ansible changes won't affect new installer.
So in openshift/openshift-ansible#9744 a new provisoner was written. So far it supports AWS only, but this might change in the future.
| @@ -0,0 +1,119 @@ | |||
| ansible_become: true | |||
There was a problem hiding this comment.
This should have been in the aws-dev directory, and when ready for CI testing should have been copied into the aws dir. The aws profile is where CI testing for AWS goes.
| openshift_additional_repos: | ||
| - id: origin | ||
| name: Origin | ||
| baseurl: "{{ lookup('env','RPM_REPO_BASEURL') }}" |
There was a problem hiding this comment.
Why did you call this RPM_REPO_BASEURL instead of RPM_REPO, which is what ci-operator generates?
There was a problem hiding this comment.
RPM_REPO is a path to .repo file and openshift-ansible doesn't have a var for a full repo file yet (see openshift/openshift-ansible#9859)
This image has been unused since the e2e template landed in 51df634 (Support an aws installer CI job, 2018-06-07, openshift#928) and since the Ansible template landed in c35a30a (Add a profile openshift-ansible custom AWS provisioner, 2018-08-30, openshift#1367). Also remove the duplicated entry from the src template which landed in aed67fc (Source installer tests should have access to IMAGE_FORMAT, 2019-01-25, openshift#2701).
5 participants
Add configuration, jobs and profile to run openshift-ansible tests on AWS
PR with custom AWS provisioner - openshift/openshift-ansible#9744
PTAL @stevekuznetsov