Bootstrap step registry with cluster-launch-e2e items #5962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/L
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
stevekuznetsov
force-pushed
the
skuznets/bootstrap-registry-contents
branch
3 times, most recently
from
868a450 to
b8a3208
Compare
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/bootstrap-registry-contents
branch
from
b8a3208 to
23ca2ce
Compare
Contributor
Author
|
/retitle Bootstrap step registry with cluster-launch-e2e items Going to get this in so we have something in the registry |
openshift-ci-robot
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
|
@stevekuznetsov: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Mar 25, 2020
The directory was from 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names.
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Mar 25, 2020
The directory was from 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names.
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Apr 6, 2020
Missing from the script since it landed in 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). We need the wait to drain out the queue before the container exits. The bare 'wait' (with no arguments) means we always exit 0, but this log gathering is already not caring about errors, so that's not a functional change.
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jun 24, 2020
The directory was from 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names.
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jun 24, 2020
The directory was from 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names, especially since openshift/ci-tools@dd11c766ed (rehearse,registry: make explicit maps for type in NodeByName, 2020-05-19, openshift/ci-tools#818).
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jan 14, 2022
We've had these in the steps since the steps were created in 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). It seems to have originally descended from 51df634 (Support an aws installer CI job, 2018-06-07, openshift#928), where it was used to copy 'oc' from the test container into the teardown container. But since the gather commands are run directly from the 'cli' image, there's no need for that sort of hoop-jumping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kuznetsov [email protected]
/cc @bbguimaraes @AlexNPavel
When we get support for the registry in rehearsal I can add a job that runs these things
TODO
jqsshandcurlcatOWNERSin these dirs