Source installer tests should have access to IMAGE_FORMAT #2701
Conversation
Components based on 4.0 but who aren't in the payload should be able
to have their test scripts get access to IMAGE_FORMAT so they can
pull the images built in the ci-operator PR pull run.
To leverage this, in your src based tests use the following in bash:
component=service-catalog
image=$(eval "echo $IMAGE_FORMAT")
which will make $image resolve to `registry.svc.ci.openshift.org/namespace/stable:service-catalog`
openshift-ci-robot
added
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@smarterclayton: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This image has been unused since the e2e template landed in 51df634 (Support an aws installer CI job, 2018-06-07, openshift#928) and since the Ansible template landed in c35a30a (Add a profile openshift-ansible custom AWS provisioner, 2018-08-30, openshift#1367). Also remove the duplicated entry from the src template which landed in aed67fc (Source installer tests should have access to IMAGE_FORMAT, 2019-01-25, openshift#2701).
4 participants
Components based on 4.0 but who aren't in the payload should be able
to have their test scripts get access to IMAGE_FORMAT so they can
pull the images built in the ci-operator PR pull run.
To leverage this, in your src based tests use the following in bash:
which will make $image resolve to
registry.svc.ci.openshift.org/namespace/stable:service-catalog