Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jan 14, 2022

We've had these in the steps since the steps were created in 23ca2ce (#5962). It seems to have originally descended from 51df634 (#928), where it was used to copy oc from the test container into the teardown container. But since the gather commands are run directly from the cli image, there's no need for that sort of hoop-jumping.

We've had these in the steps since the steps were created in
23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962).
It seems to have originally descended from 51df634 (Support an aws
installer CI job, 2018-06-07, openshift#928), where it was used to copy 'oc'
from the test container into the teardown container.  But since the
gather commands are run directly from the 'cli' image, there's no need
for that sort of hoop-jumping.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@wking
Copy link
Member Author

wking commented Jan 14, 2022

Some green, and no complaints:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/25263/rehearse-25263-pull-ci-openshift-windows-machine-config-operator-release-4.9-aws-e2e-operator/1481779674282463232/artifacts/aws-e2e-operator/gather-extra/build-log.txt | grep 'command not found'

So I think this is good to merge.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/kubernetes/release-4.9/configmap-scale 50bb414 link unknown /test pj-rehearse
ci/prow/pj-rehearse 50bb414 link false /test pj-rehearse
ci/rehearse/openshift/cluster-capi-operator/release-4.11/e2e-aws-capi-techpreview 50bb414 link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.11/aws-e2e-ccm-install 50bb414 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 79f78fa into openshift:master Jan 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@wking: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key gather-extra-commands.sh using file ci-operator/step-registry/gather/extra/gather-extra-commands.sh
  • key gather-libvirt-commands.sh using file ci-operator/step-registry/gather/libvirt/gather-libvirt-commands.sh
Details

In response to this:

We've had these in the steps since the steps were created in 23ca2ce (#5962). It seems to have originally descended from 51df634 (#928), where it was used to copy oc from the test container into the teardown container. But since the gather commands are run directly from the cli image, there's no need for that sort of hoop-jumping.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-tmp-shared-from-PATH branch January 25, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants