Bug 1841066: OpenStack: Remove DNS VIP #1666
Conversation
|
Depends on #1659 |
|
/test e2e-openstack |
|
/retest |
mandre
changed the title
|
@mandre: This pull request references Bugzilla bug 1841066, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-high
|
/test e2e-openstack |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
/retest |
|
/test e2e-metal-ipi |
Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity. We already do this on the workers because they never had a dependency on the bootstrap coredns so the same method is now used for masters. This brings the BM change openshift#1569 to OpenStack platform.
This commits follow [1][2] in removing DNS VIP. Taken from [2]: "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity." [1] openshift#1569 [2] openshift#1666 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
|
/test e2e-openstack |
|
/approve |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel e2e-openstack tests are passing. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamemilio, kikisdeliveryservice, mandre, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@mandre I think there are some issues in 4.6 CI rn, but approved so bot can retest and merge.. |
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest e2e-aws |
|
@pierreprinetti: The
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws |
|
@mandre: Some pull requests linked via external trackers have merged: openshift/machine-config-operator#1666. The following pull requests linked via external trackers have not merged:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commits follow [1][2] in removing DNS VIP. Taken from [2]: "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity." [1] openshift#1569 [2] openshift#1666 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
This commits follow [1][2] in removing DNS VIP. Taken from [2]: "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity." [1] openshift#1569 [2] openshift#1666 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
We're removed the DNS VIP from the picture [1][2], however we forgot to update the docs. [1] openshift/machine-config-operator#1666 [2] openshift#3492
7 participants
Now that etcd does not need DNS for clustering, we no longer need to
have a VIP to allow the masters to use the bootstrap coredns until
their own coredns instances start. Instead, we can just point them
at the local coredns directly and skip the extra complexity. We
already do this on the workers because they never had a dependency
on the bootstrap coredns so the same method is now used for masters.
This brings the BM change #1569 to OpenStack platform.