Bug 1826211: drop python usage for node-ip functionality #1659
Conversation
Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity. We already do this on the workers because they never had a dependency on the bootstrap coredns so the same method is now used for masters.
|
/assign @LorbusChris @bcrochet @cybertron @yboaron |
|
/assign @mandre |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
celebdor
force-pushed
the
baremetal-runtimecfg-nodeip
branch
4 times, most recently
from
c77694a to
de6b027
Compare
|
verified to work on both masters and workers. |
|
/retest |
openshift-ci-robot
added
the
approved
|
/retest |
Recently the non_virtual_ip and nodeip-finder functionality was implemented in golang on the baremetal-runtimecfg repository. This commit changes the baremetal and the openstack platforms to use the golang implementation via podman, so we do not block rhcos dropping platform-python. Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
celebdor
force-pushed
the
baremetal-runtimecfg-nodeip
branch
from
de6b027 to
c4bb6f8
Compare
|
/lgtm Just fixed an incorrect reference in the OpenStack templates. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retitle Bug 1826211: drop python usage for node-ip functionality |
openshift-ci-robot
changed the title
|
@celebdor: This pull request references Bugzilla bug 1826211, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@celebdor: This pull request references Bugzilla bug 1826211, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@celebdor: This pull request references Bugzilla bug 1826211, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-gcp-op |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@celebdor: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1659. Bugzilla bug 1826211 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
10 participants
Recently the non_virtual_ip and nodeip-finder functionality was
implemented in golang on the baremetal-runtimecfg repository. This
commit changes the baremetal and the openstack platforms to use the
golang implementation via podman, so we do not block rhcos dropping
platform-python.
If baremetal IPI clusters, it means it works. This obsoletes #1564 but needs openshift/baremetal-runtimecfg#57 to merge first