baremetal: Remove DNS VIP #1569
Conversation
openshift-ci-robot
added
the
approved
|
/label platform/baremetal |
|
@stbenjam: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Oh didn't realize the repo I was in -- will try |
|
Will this get removed from the install-config as well? |
|
@cybertron can you please also post a draft documentation update to the openshift/installer repo that reflects this change? |
good point - this could be in the same draft PR as the docs change I just requested |
|
Adding hold until the above comments are addressed. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
Yes, I also need to remove the DNS VIP from the installer. I'm working on that patch now. This will need to go in first though since the current templates have a dependency on the VIP being populated by the installer. |
|
/cc @mandre @jcpowermac i think something like this is needed for openstack and vsphere too right? |
|
/test e2e-gcp-upgrade |
Use of this field is being removed in [0] and [1]. Once those two PRs have merged there will no longer be any use for it. 0: openshift/machine-config-operator#1569 1: openshift/installer#3304
|
installer change is proposed here: openshift/installer#3304 I expect that the other platforms can remove this too. /cc @rgolangh for ovirt also. |
Use of this field is being removed in [0] and [1]. Once those two PRs have merged there will no longer be any use for it. 0: openshift/machine-config-operator#1569 1: openshift/installer#3304
This just needs a LGTM and you can let the bot retest for you after |
|
/retest |
Ah, so that's why the bot sometimes retests and sometimes doesn't. TIL, thanks. :-) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, celebdor, cybertron, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Align with current updates to baremetal See PR openshift#1569 "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity. We already do this on the workers because they never had a dependency on the bootstrap coredns so the same method is now used for masters."
|
/refresh |
|
/test e2e-gcp-upgrade |
1 similar comment
|
/test e2e-gcp-upgrade |
|
/retest |
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Use of this setting is being removed in [0]. Once that goes in we can remove it from the installer as well. 0: openshift/machine-config-operator#1569
Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity. We already do this on the workers because they never had a dependency on the bootstrap coredns so the same method is now used for masters. This brings the BM change openshift#1569 to OpenStack platform.
This commits follow [1][2] in removing DNS VIP. Taken from [2]: "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity." [1] openshift#1569 [2] openshift#1666 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
This commits follow [1][2] in removing DNS VIP. Taken from [2]: "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity." [1] openshift#1569 [2] openshift#1666 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
This commits follow [1][2] in removing DNS VIP. Taken from [2]: "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity." [1] openshift#1569 [2] openshift#1666 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
12 participants
Now that etcd does not need DNS for clustering, we no longer need to
have a VIP to allow the masters to use the bootstrap coredns until
their own coredns instances start. Instead, we can just point them
at the local coredns directly and skip the extra complexity. We
already do this on the workers because they never had a dependency
on the bootstrap coredns so the same method is now used for masters.