Skip to content

Bug 1841066: OpenStack: Remove DNS VIP #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 5, 2020
Merged

Bug 1841066: OpenStack: Remove DNS VIP #3492

openshift-merge-robot merged 1 commit into from
Jun 5, 2020

Conversation

@mandre
Copy link
Member

@mandre mandre commented Apr 22, 2020

@mandre
Copy link
Member Author

mandre commented Apr 22, 2020

/label platform/openstack
/cc @pierreprinetti @Fedosin

@abhinavdahiya abhinavdahiya mentioned this pull request May 8, 2020
Closed
@pierreprinetti
Copy link
Member

pierreprinetti commented May 12, 2020

/retest

@mandre
Copy link
Member Author

mandre commented May 12, 2020

We need openshift/machine-config-operator#1666 to merge first.

@mandre mandre mentioned this pull request May 19, 2020
Closed
@iamemilio
Copy link

iamemilio commented May 27, 2020

/retest

@mandre mandre changed the title OpenStack: Remove DNS VIP Bug 1841066: OpenStack: Remove DNS VIP May 28, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 28, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2020

@mandre: This pull request references Bugzilla bug 1841066, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1841066: OpenStack: Remove DNS VIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 3, 2020
Merged
@mandre
Copy link
Member Author

mandre commented Jun 3, 2020

/recheck

@mandre
Copy link
Member Author

mandre commented Jun 3, 2020

/test e2e-openstack

2 similar comments
@mandre
Copy link
Member Author

mandre commented Jun 3, 2020

/test e2e-openstack

@mandre
Copy link
Member Author

mandre commented Jun 3, 2020

/test e2e-openstack

@pierreprinetti
Copy link
Member

pierreprinetti commented Jun 3, 2020

/approve
/lgtm
/hold until e2e-openstack is successful
/meow

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 3, 2020

@pierreprinetti: cat image

Details

In response to this:

/approve
/lgtm
/hold until e2e-openstack is successful
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020
@mandre
Copy link
Member Author

mandre commented Jun 3, 2020

/hold cancel
tests are passing

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@mandre
Copy link
Member Author

mandre commented Jun 4, 2020

/assign sdodson
for approval :)

@sdodson
Copy link
Member

sdodson commented Jun 4, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5face7c into openshift:master Jun 5, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 5, 2020

@mandre: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1666, openshift/installer#3492. Bugzilla bug 1841066 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1841066: OpenStack: Remove DNS VIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Contributor

jichenjc commented Jun 16, 2020

@mandre do we plan to backport this PR to 4.5 or keep it to master (so it will be 4.6?)
seems https://github.com/openshift/installer/blob/release-4.5/data/data/openstack/bootstrap/main.tf still has DNS VIP in the code

mandre added a commit to mandre/installer that referenced this pull request Jun 25, 2020
@mandre
Docs: DNS VIP no longer exists
dd40179 
We're removed the DNS VIP from the picture [1][2], however we forgot to
update the docs.

[1] openshift/machine-config-operator#1666
[2] openshift#3492
@mandre mandre mentioned this pull request Jun 25, 2020
Merged
@mandre mandre deleted the openstack-dns-vip branch September 17, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@sdodson sdodson

@pierreprinetti pierreprinetti

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mandre @pierreprinetti @iamemilio @openshift-ci-robot @sdodson @openshift-bot @jichenjc @openshift-merge-robot