Bug 1843010: Remove dns vip #1775
Conversation
On ocp 4.6 rchos removed dhclient, so we need to decided to move away from using the DNSVIP. This patch adds NM dispatcher 30-resolv-prepender script to append the nameserver to /etc/resolv.conf. Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
This commits follow [1][2] in removing DNS VIP. Taken from [2]: "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity." [1] openshift#1569 [2] openshift#1666 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
openshift-ci-robot
added
bugzilla/severity-high
|
@Gal-Zaidman: This pull request references Bugzilla bug 1843010, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @rgolangh |
Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@Gal-Zaidman: This pull request references Bugzilla bug 1843010, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ? |
|
@Gal-Zaidman: The following commands are available to trigger jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-ovirt |
3 similar comments
|
/test e2e-ovirt |
|
/test e2e-ovirt |
|
/test e2e-ovirt |
ashcrow
requested review from
kikisdeliveryservice and
yuqi-zhang
and removed request for
ashcrow
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
Afaik e2e aws is a mess rn, but approving bc this makes sense as the other platforms have done this as well. Defer to @rgolangh for final LGTM and will let ovirt team investigate their CI job..
openshift-ci-robot
added
the
approved
|
actually adding hold to prevent accidental merging without a clear signal/decision on the ovirt job for now :) /hold |
openshift-ci-robot
added
the
do-not-merge/hold
Just for tracking. Could you please also mention: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougsland, Gal-Zaidman, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-scaleup-rhel7 |
|
ovirt job passed /hold cancel |
|
rhel7/metal-ipi jobs are flaky and unaffected by this pr /skip |
kikisdeliveryservice
removed
the
do-not-merge/hold
|
@Gal-Zaidman you can do a cherry pick on this to get 4.5 backport it will also create a BZ for you. |
|
@Gal-Zaidman: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
@Gal-Zaidman: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1775. Bugzilla bug 1843010 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-ovirt |
|
/cherry-pick release-4.5 |
|
@Gal-Zaidman: new pull request created: #1782 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@Gal-Zaidman: #1775 failed to apply on top of branch "release-4.4": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
This PR follow [1][2][3] in removing DNS VIP.
This PR solves the issue with the removal of dhclient on rchos for ocp 4.6 and is a first step from removing DNSVIP.
Taken from [2]:
"Now that etcd does not need DNS for clustering, we no longer need to
have a VIP to allow the masters to use the bootstrap coredns until
their own coredns instances start. Instead, we can just point them
at the local coredns directly and skip the extra complexity."
[1] #1569
[2] #1666
[3] #1773