Skip to content

bug 2005901: Guard controller pdb#373

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ingvagabund:guard-controller-pdb
Jan 3, 2022
Merged

bug 2005901: Guard controller pdb#373
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ingvagabund:guard-controller-pdb

Conversation

@ingvagabund
Copy link
Copy Markdown
Member

@ingvagabund ingvagabund commented Oct 27, 2021 •
edited
Loading

Running in my cluster (after deploying the scheduler operator with the changes)

NAME                                                                  READY   STATUS    RESTARTS   AGE
openshift-kube-scheduler-ip-10-0-144-236.us-east-2.compute.internal   3/3     Running   0          13m
openshift-kube-scheduler-ip-10-0-169-240.us-east-2.compute.internal   3/3     Running   0          15m
openshift-kube-scheduler-ip-10-0-227-47.us-east-2.compute.internal    3/3     Running   0          55s
NAME                                                                        READY   STATUS    RESTARTS   AGE
openshift-kube-scheduler-guard-ip-10-0-144-236.us-east-2.compute.internal   1/1     Running   0          94s
openshift-kube-scheduler-guard-ip-10-0-169-240.us-east-2.compute.internal   1/1     Running   0          91s
openshift-kube-scheduler-guard-ip-10-0-227-47.us-east-2.compute.internal    1/1     Running   0          87s

/hold
TBD

Pulling openshift/library-go#1238

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 27, 2021
@openshift-ci openshift-ci Bot requested review from damemi and sttts October 27, 2021 10:42
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@ingvagabund ingvagabund mentioned this pull request Oct 27, 2021
Merged
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2021
@ingvagabund ingvagabund changed the title WIP: Guard controller pdb Guard controller pdb Nov 15, 2021
@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Nov 15, 2021

Waiting for openshift/library-go#1238

@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 15, 2021
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2021
@ingvagabund ingvagabund force-pushed the guard-controller-pdb branch 2 times, most recently from 52c4e97 to 073359a Compare December 8, 2021 10:13
@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Dec 17, 2021

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2021
@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Dec 17, 2021

/retest

@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Dec 17, 2021

Checking https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-scheduler-operator/373/pull-ci-openshift-cluster-kube-scheduler-operator-master-e2e-aws/1471815198951084032/artifacts/e2e-aws/gather-extra/artifacts/pods/:

 openshift-kube-scheduler_openshift-kube-scheduler-guard-ip-10-0-154-38.us-west-2.compute.internal_guard.log
 openshift-kube-scheduler_openshift-kube-scheduler-guard-ip-10-0-154-38.us-west-2.compute.internal_guard_previous.log
 openshift-kube-scheduler_openshift-kube-scheduler-guard-ip-10-0-170-57.us-west-2.compute.internal_guard.log
 openshift-kube-scheduler_openshift-kube-scheduler-guard-ip-10-0-170-57.us-west-2.compute.internal_guard_previous.log
 openshift-kube-scheduler_openshift-kube-scheduler-guard-ip-10-0-241-117.us-west-2.compute.internal_guard.log
 openshift-kube-scheduler_openshift-kube-scheduler-guard-ip-10-0-241-117.us-west-2.compute.internal_guard_previous.log

soltysh
soltysh approved these changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Dec 17, 2021

/test

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 17, 2021

@ingvagabund: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-aws-operator
  • /test e2e-aws-operator-preferred-host
  • /test e2e-aws-serial
  • /test e2e-upgrade
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

Use /test all to run all jobs.

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Dec 17, 2021

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021
@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Dec 26, 2021

/retest

1 similar comment
@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Dec 28, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 28, 2021

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Jan 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ingvagabund,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund ingvagabund changed the title Guard controller pdb bug 2005901: Guard controller pdb Jan 3, 2022
@openshift-ci openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 3, 2022

@ingvagabund: This pull request references Bugzilla bug 2005901, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

Details

In response to this:

bug 2005901: Guard controller pdb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 3, 2022
@openshift-ci openshift-ci Bot requested a review from kasturinarra January 3, 2022 11:01
@openshift-merge-robot openshift-merge-robot merged commit ca15890 into openshift:master Jan 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 3, 2022

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 2005901 has been moved to the MODIFIED state.

Details

In response to this:

bug 2005901: Guard controller pdb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the guard-controller-pdb branch January 3, 2022 11:22
@openshift-ci openshift-ci Bot mentioned this pull request Jan 12, 2022
Merged
This was referenced Jan 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damemi damemi Awaiting requested review from damemi

@sttts sttts Awaiting requested review from sttts

@kasturinarra kasturinarra Awaiting requested review from kasturinarra

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ingvagabund @openshift-bot @soltysh @openshift-merge-robot