Download yq in upi installer containers
#6008
Conversation
Various CI steps use the upi-installer container for it's access to the aws cli tools among other things. However, most of those steps also curl `yq` directly from GitHub. We can save ourselves some headaches when GitHub is down by just embedding the binary in the image already. Note, this also removes the python yq which I am not sure if it's used, but I can't find a place where it is.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ci/prow/images |
|
@stbenjam: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test images |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Someplace calling the python yq, e.g: in ci-operator/step-registry/ipi/conf/azurestack/rhcos/ipi-conf-azurestack-rhcos-commands.sh: |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Python yq is used in azure(stack) upi jobs. Perhaps upi jobs on other platforms. /lgtm cancel |
|
maybe we can save the yq to a different filename, just like what I did in #6006 ? |
|
/hold cancel I wrote go yq to a different path (/bin/yq-go). |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/override ci/prow/e2e-azure-upi |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/skip |
|
/skip |
|
/test e2e-gcp |
|
/override ci/prow/e2e-azure-upi |
|
@jianlinliu: jianlinliu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/skip ci/prow/e2e-azure-upi |
|
/test e2e-ibmcloud |
|
/test e2e-metal-ipi |
|
/skip |
|
/override ci/prow/e2e-azure-upi |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
9 participants
TRT-319
Various CI steps use the upi-installer container for it's access to the
aws cli tools among other things. However, most of those steps also
curl
yqdirectly from GitHub. We can save ourselves some headacheswhen GitHub is down by just embedding the binary in the image already.