Skip to content

migrate cri-o CI to gcp #30733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 9, 2022
Merged

migrate cri-o CI to gcp #30733

openshift-merge-robot merged 1 commit into from
Sep 9, 2022

Conversation

@wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Jul 22, 2022 •
edited
Loading

moves the cri-o CI away from equinix to GCP

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2022
@openshift-ci openshift-ci bot requested review from QiWang19 and bbguimaraes July 22, 2022 14:23
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 26, 2022

/retest

1 similar comment
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 26, 2022

/retest

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 26, 2022

/retest

1 similar comment
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 27, 2022

/retest

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 27, 2022

/pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 27, 2022

/test pj-rehearse

11 similar comments
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 27, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 29, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 29, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Jul 29, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 1, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 1, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 1, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 1, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 1, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 1, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 1, 2022

/test pj-rehearse

@sohankunkerkar
Copy link
Member

sohankunkerkar commented Aug 2, 2022

/retest

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 2, 2022

/test pj-rehearse

3 similar comments
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 2, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 3, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 3, 2022

/test pj-rehearse

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 4, 2022

/retest

3 similar comments
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 4, 2022

/retest

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 5, 2022

/retest

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Aug 5, 2022

/retest

QiWang19
QiWang19 reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@QiWang19 QiWang19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jianlinliu
jianlinliu reviewed Sep 2, 2022
View reviewed changes
ci-operator/step-registry/gcp/OWNERS Outdated
Copy link
Contributor

@jianlinliu jianlinliu Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once you are the OWNER of bastionhost, no need to change this file.

jianlinliu
jianlinliu reviewed Sep 2, 2022
View reviewed changes
ci-operator/step-registry/gcp/deprovision/buildhost/OWNERS Outdated
Copy link
Contributor

@jianlinliu jianlinliu Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can drop the gpei, jianlinliu and jianli-wei from the OWNER list for the buildhost ref.

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 2, 2022

btw, do you mind squashing multiple commit into one after fixed all the comments.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Sep 6, 2022

/retest

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 7, 2022

There are two comments are not resolved yet:

#30733 (comment)

#30733 (comment)

@wgahnagl wgahnagl force-pushed the ci-gcp branch 3 times, most recently from 1747ed4 to 73992a1 Compare September 7, 2022 19:22
jianlinliu
jianlinliu reviewed Sep 8, 2022
View reviewed changes
ci-operator/step-registry/gcp/OWNERS Outdated
Copy link
Contributor

@jianlinliu jianlinliu Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant you can create a plain OWNER file under gcp/{provision,deprovision}/buildhost/, then place your team member as owners for the newly created steps, but not touch with parent folder's OWNER list.

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Sep 8, 2022

/retest

@haircommander
Copy link
Member

haircommander commented Sep 8, 2022

@jianlinliu if there are remaining issues in your work day, would you mind if we handled them as a follow up? our CI has been broken for a week and a half in anticipation of this, so we're eager to merge this to have some working CI in the interim

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 9, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, jianlinliu, rphillips, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 9, 2022

if there are remaining issues in your work day, would you mind if we handled them as a follow up?

I will submit a followup PR to fix the remaining issues to save time.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@wgahnagl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/cri-o/cri-o/ci-gcp/critest 7ac2043 link unknown /test pj-rehearse
ci/rehearse/cri-o/cri-o/ci-gcp/images 7ac2043 link unknown /test pj-rehearse
ci/rehearse/cri-o/cri-o/ci-gcp/integration 7ac2043 link unknown /test pj-rehearse
ci/rehearse/cri-o/cri-o/ci-gcp/e2e 7ac2043 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-e2e-gcp-upi-proxy-p2 1a645c6 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-e2e-gcp-ipi-private-p1 1a645c6 link unknown /test pj-rehearse
ci/rehearse/cri-o/cri-o/main/equinix-critest b8f38c5a000623cef98bc1f7209784c5ceb5ba7c link unknown /test pj-rehearse
ci/rehearse/cri-o/cri-o/main/equinix-integration b8f38c5a000623cef98bc1f7209784c5ceb5ba7c link unknown /test pj-rehearse
ci/rehearse/cri-o/cri-o/main/equinix-e2e b8f38c5a000623cef98bc1f7209784c5ceb5ba7c link unknown /test pj-rehearse
ci/prow/pj-rehearse fb97b5e link false /test pj-rehearse
ci/rehearse/cri-o/cri-o/main/ci-integration fb97b5e link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5d1d6a7 into openshift:master Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@wgahnagl: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key cri-o-cri-o-main__ci.yaml using file ci-operator/config/cri-o/cri-o/cri-o-cri-o-main__ci.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key cri-o-cri-o-main-presubmits.yaml using file ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-main-presubmits.yaml
Details

In response to this:

moves the cri-o CI away from equinix to GCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianlinliu jianlinliu mentioned this pull request Sep 9, 2022
Merged
@derekhiggins derekhiggins mentioned this pull request Sep 9, 2022
Closed
@haircommander haircommander mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

3 more reviewers

@rphillips rphillips rphillips left review comments

@jianlinliu jianlinliu jianlinliu left review comments

@QiWang19 QiWang19 QiWang19 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rphillips rphillips

@jianlinliu jianlinliu

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wgahnagl @sohankunkerkar @rphillips @haircommander @jianlinliu @QiWang19 @openshift-merge-robot