Verifying yq is installed properly in libvirt installer containers

[deepsm007]

Found recent failure in CI with incorrectly downloaded yq
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-e2e-sdn-remote-libvirt-ppc64le/1567624076510367744#1:build-log.txt%3A34-40

cc @r4f4

[deepsm007]

/assign @patrickdillon

[r4f4]

This looks in line to how it's done in UPI: #6008. I'll wait on the e2e-libvirt job before giving a lgtm.

[r4f4]

/lgtm

[sadasu]

Is #6008 doing the same thing?

[r4f4]

Is #6008 doing the same thing?

@sadasu the change is similar but different semantics. #6008 was adding yq binary to the upi Dockerfile (instead of downloading it every time in the CI jobs), whereas this PR is adding the checksum verification of the downloaded yq to the libvirt Dockerfile.

[sadasu]

/test e2e-libvirt

[deepsm007]

/test e2e-libvirt

[barbacbd]

/test e2e-libvirt

[r4f4]

e2e-libvirt has been permafailing when fetching the test results with error: failed to create/update secret: failed to update secret: Secret "e2e-libvirt" is invalid: data: Too long: must have at most 1048576 bytes. But the building of the libvirt-installer has been successful, which is what this PR is touching.

[deepsm007]

@patrickdillon can we get this merged?

[patrickdillon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cde9393 and 2 for PR HEAD db7deb6 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9885f6b and 1 for PR HEAD db7deb6 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e85c561 and 0 for PR HEAD db7deb6 in total

[sadasu]

/override ci/prow/e2e-libvirt

[openshift-ci]

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/e2e-libvirt

Details

In response to this:

/override ci/prow/e2e-libvirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.