install yq in upi installer image #6006
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jianlinliu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| ENV CLOUDSDK_PYTHON=/usr/bin/python | ||
|
|
||
| RUN python3 -m pip install yq | ||
| RUN curl -L https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64 -o /bin/yq-3.3.0 && chmod +x /bin/yq-3.3.0 |
There was a problem hiding this comment.
nit: isn't it better to just set it to yq instead of yq-3.3.0? We call this version of yq everywhere anyway
| RUN curl -L https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64 -o /bin/yq-3.3.0 && chmod +x /bin/yq-3.3.0 | |
| RUN curl -L https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64 -o /bin/yq-3.3.0 && chmod +x /bin/yq |
There was a problem hiding this comment.
also change the output file to /bin/yq
There was a problem hiding this comment.
- In release repo, there is some place downloading v4.13.5, to avoid future conflicts, I named the yq tools with version number.
$ grep -r "yq/releases/download" |grep -v 3.3.0
ci-operator/jobs/openshift/release/openshift-release-release-4.3-periodics.yaml: curl -L https://github.com/mikefarah/yq/releases/download/2.4.0/yq_linux_amd64 2>/dev/null >/tmp/bin/yq
ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml: curl -L https://github.com/mikefarah/yq/releases/download/2.4.0/yq_linux_amd64 2>/dev/null >/tmp/bin/yq
ci-operator/jobs/openshift/release/openshift-release-release-4.5-periodics.yaml: curl -L https://github.com/mikefarah/yq/releases/download/2.4.0/yq_linux_amd64 2>/dev/null >/tmp/bin/yq
ci-operator/step-registry/assisted/baremetal/operator/publish/assisted-baremetal-operator-publish-commands.sh:curl -L https://github.com/mikefarah/yq/releases/download/v4.13.5/yq_linux_amd64 -o /tmp/yq && chmod +x /tmp/yq
ci-operator/config/redhat-developer/service-binding-operator/redhat-developer-service-binding-operator-master.yaml: RUN curl -Lk -o /usr/bin/yq https://github.com/mikefarah/yq/releases/download/v4.18.1/yq_linux_amd64 && chmod +x /usr/bin/yq
- On the line 46, another yq is installed from pip, to avoid confusion, I named it with version number. E.g: in ci-operator/step-registry/ipi/conf/azurestack/rhcos/ipi-conf-azurestack-rhcos-commands.sh
yq --arg url "${vhd_blob_url}" -i -y '.platform.azure.ClusterOSImage=$url' "${SHARED_DIR}/install-config.yaml"
It is using yq installed from pip
| rm -rf /var/cache/yum/* && \ | ||
| chmod g+w /etc/passwd | ||
|
|
||
| RUN curl -L https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64 -o /bin/yq-3.3.0 && chmod +x /bin/yq-3.3.0 |
There was a problem hiding this comment.
Above comments should be applied here.
Good to know. Sure, closing. |
4 participants
In https://github.com/openshift/release, there are many places downloading https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64, move it to upi installer image, will save bandwidth and reduce network race condition.