Skip to content

OCPQE-13626 yaml module is not available in ocp/4.8:upi-installer image #36002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 7, 2023
Merged

OCPQE-13626 yaml module is not available in ocp/4.8:upi-installer image #36002

openshift-merge-robot merged 1 commit into from
Feb 7, 2023

Conversation

@yunjiang29
Copy link
Contributor

@yunjiang29 yunjiang29 commented Feb 3, 2023 •
edited
Loading

Resolve issue https://issues.redhat.com/browse/OCPQE-13626, replace python pyyaml module with yq-go

yq-go has been installed in:

Current python3 yaml solution is applicable for 4.10+, after apply this fix it will be applicable for 4.8+

Tests:

  • rehearse-36002-periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28: link
  • rehearse-36002-periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-upi-p3-f28: link
  • rehearse-36002-periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-nightly-azure-upi-p3-f28 link

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 3, 2023

@yunjiang29: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-aws-ovn-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.14-e2e-aws-ovn-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-aws-ovn-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.12-e2e-aws-ovn-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.11-e2e-aws-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-e2e-aws-upi-proxy openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.14-e2e-aws-upi-proxy openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-aws-upi-proxy openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.12-e2e-aws-upi-proxy openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.11-e2e-aws-upi-proxy openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-e2e-azure-ovn-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.14-e2e-azure-ovn-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-azure-ovn-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.12-e2e-azure-ovn-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.11-e2e-azure-upi openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.10-e2e-azure-upi openshift/installer presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-arm64-stable-aws-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-azure-upi-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.9-amd64-stable-azure-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.9-amd64-nightly-azure-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-arm64-nightly-aws-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-upi-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.9-amd64-stable-azure-upi-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-aws-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-azure-upi-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-azure-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-4.12-upgrade-from-stable-4.11-azure-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.9-e2e-azure-upi N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-azure-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-e2e-aws-upi-ovn-arm64 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-stable-aws-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-azure-upi-p3-f28-destructive N/A periodic Registry content changed

A total of 89 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 3, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 3, 2023

@jinyunma @jianlinliu @gpei please take a look, let me know if any potential issues, thanks.

<= 4.7 is not supported, I listed tool's availability here

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 3, 2023

/pj-rehearse pull-ci-openshift-installer-release-4.11-e2e-aws-upi-proxy

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 3, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 3, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-nightly-azure-upi-p3-f28

@jianlinliu
Copy link
Contributor

jianlinliu commented Feb 3, 2023

From https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/36002/rehearse-36002-periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28/1621406355195695104, seem like we hit another script bug.

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-nightly-azure-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse pull-ci-openshift-installer-release-4.11-e2e-aws-upi-proxy

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-nightly-azure-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse pull-ci-openshift-installer-release-4.11-e2e-aws-upi-proxy

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse pull-ci-openshift-installer-release-4.11-e2e-aws-upi-proxy

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-nightly-azure-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse pull-ci-openshift-installer-release-4.11-e2e-aws-upi-proxy

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 6, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-upi-p3-f28

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 7, 2023

/pj-rehearse pull-ci-openshift-installer-release-4.11-e2e-aws-upi-proxy

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 7, 2023

@jianlinliu PTAL, it's ready for merge now, see test result in #36002 (comment)

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 7, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2023
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Feb 7, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 7, 2023
@bear-redhat
Copy link
Contributor

bear-redhat commented Feb 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bear-redhat, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

@yunjiang29: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-nightly-azure-upi-p3-f28 86eb80aa855862f860709c7f48e31a8ea3bd0d25 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-nightly-azure-upi-p3-f28
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28 86eb80aa855862f860709c7f48e31a8ea3bd0d25 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-aws-upi-p3-f28
ci/rehearse/openshift/installer/release-4.11/e2e-aws-upi-proxy a1d0ac09ed3deb79a2db155dd326e425085db73a link unknown /pj-rehearse pull-ci-openshift-installer-release-4.11-e2e-aws-upi-proxy
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-upi-p3-f28 86eb80aa855862f860709c7f48e31a8ea3bd0d25 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-upi-p3-f28

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f8c93f0 into openshift:master Feb 7, 2023
@yunjiang29 yunjiang29 deleted the upi-yaml branch July 21, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bear-redhat bear-redhat Awaiting requested review from bear-redhat

@danilo-gemoli danilo-gemoli Awaiting requested review from danilo-gemoli

Assignees

@bear-redhat bear-redhat

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yunjiang29 @openshift-ci-robot @jianlinliu @bear-redhat @openshift-merge-robot