*: remove the deprecated kube-system coreos-pull-secret

[abhinavdahiya]

PR #1554 marked kube-system coreos-pull-secret deprecated in favor of openshift-config pull-secret

consumer PRs like openshift/origin#22508 openshift/machine-config-operator#609 should allow removal now.

[wking]

e2e-aws:

level=fatal msg="failed to initialize the cluster: Could not update servicemonitor \"openshift-service-catalog-apiserver-operator/openshift-service-catalog-apiserver-operator\" (288 of 307): the server does not recognize this resource, check extension API servers: timed out waiting for the condition"

Discussion in rhbz#1680201.

/retest

[wking]

/lgtm

Although this may not pass until openshift/origin#22508 actually lands (it's currently in the merge queue).

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[wking]

e2e-aws:

fail [github.com/openshift/origin/test/extended/operators/images.go:28]: Apr 10 21:52:39.464: unable to get pull secret for cluster: secrets "coreos-pull-secret" not found
...
Flaky tests:

[Feature:DeploymentConfig] deploymentconfigs with failing hook [Conformance] should get all logs from retried hooks [Suite:openshift/conformance/parallel/minimal]

Failing tests:

[Feature:Platform][Smoke] Managed cluster should ensure pods use images from our release image with proper ImagePullPolicy [Suite:openshift/conformance/parallel]
[Feature:Prometheus][Conformance] Prometheus when installed on the cluster should start and expose a secured proxy and unsecured metrics [Suite:openshift/conformance/parallel/minimal]

/hold

Until openshift/origin#22508 lands.

[abhinavdahiya]

/retest

[abhinavdahiya]

openshift/origin#22508 merged
openshift/cluster-monitoring-operator#315 merged

so ^^ should close the loop on all the consumers.

/hold cancel

[abhinavdahiya]

e2e-aws failure: rate limited:

level=error msg="Error: Error applying plan:"
level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.vpc.aws_route.igw_route: 1 error occurred:"
level=error msg="\t* aws_route.igw_route: Error creating route: timeout while waiting for state to become 'success' (timeout: 2m0s)"

/retest

[abhinavdahiya]

Failing tests:

[Feature:Platform] Managed cluster should have no crashlooping pods in core namespaces over two minutes [Suite:openshift/conformance/parallel]

looks like deleting the pull-secret didn't create any problems. :yay:

/retest

[abhinavdahiya]

/retest