Bug 1697644: operator: use openshift-config/pull-secret to fetch the pull secret for cloud.openshift.com#315
Conversation
openshift-ci-robot
added
the
size/S
| }) | ||
|
|
||
| o.openshiftConfigCmapInf = cache.NewSharedIndexInformer( | ||
| o.client.ConfigMapListWatchForNamespace("openshift-config"), |
There was a problem hiding this comment.
Why are we watching for configmap changes in this namespace?
There was a problem hiding this comment.
Oh, brain fart :). didn't see that the informer was for configmap.
is there any other informer that needs setup so that the operator is responding to changes to this secret or no sync was setup for previous secret location too.
…or cloud.openshift.com The operator should be using the openshift-config/pull-secret as the kube-system/coreos-pull-secret has been marked deprecated.
abhinavdahiya
force-pushed
the
move-pull-secret
branch
from
b48cdcc to
c2cedc4
Compare
openshift-ci-robot
added
size/XS
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Friendly ping @squat |
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
/lgtm
Perfect. Thanks Abhinav!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, squat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
The operator should be using the openshift-config/pull-secret as the kube-system/coreos-pull-secret has been marked deprecated.
/cc @derekwaynecarr @smarterclayton