Skip to content

Bug 1697644: operator: use openshift-config/pull-secret to fetch the pull secret for images. #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 9, 2019
Merged

Bug 1697644: operator: use openshift-config/pull-secret to fetch the pull secret for images. #609

openshift-merge-robot merged 1 commit into from
Apr 9, 2019

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Apr 8, 2019

- What I did

The operator should be using the openshift-config/pull-secret as the kube-system/coreos-pull-secret has been marked deprecated.

- Description for the changelog

Use openshift-config/pull-secret as source for pull secret for images

requires: openshift/installer#1554
/cc @smarterclayton

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2019
@runcom
Copy link
Member

runcom commented Apr 8, 2019

/approve

/hold

holding until dep is merged in installer

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 8, 2019
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 8, 2019 •
edited
Loading

this lgtm pending installer PR and CI running green after that PR is in.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 8, 2019

actually, @abhinavdahiya type in the title of PR and commit message "opertor" -> "operator"

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 8, 2019

could you also add the content from the What I did section here ("The operator..." to the commit message body?

@abhinavdahiya
operator: use openshift-config/pull-secret to fetch the pull secret f…
b055b49 
…or images.

The operator should be using the openshift-config/pull-secret as the kube-system/coreos-pull-secret has been marked deprecated.
@abhinavdahiya abhinavdahiya changed the title opertor: use openshift-config/pull-secret to fetch the pull secret for images. operator: use openshift-config/pull-secret to fetch the pull secret for images. Apr 8, 2019
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 8, 2019

thanks for the changes! 😄

@abhinavdahiya abhinavdahiya changed the title operator: use openshift-config/pull-secret to fetch the pull secret for images. Bug 1697644: operator: use openshift-config/pull-secret to fetch the pull secret for images. Apr 8, 2019
@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Apr 8, 2019

openshift/installer#1554 (comment) merged

/retest

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 9, 2019

did the change not make it to images & e2e-aws-op yet?

could not copy stable-initial imagestreamtag: Timeout: request did not complete within allowed duration

@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Apr 9, 2019

/retest

@runcom
Copy link
Member

runcom commented Apr 9, 2019

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 9, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abhinavdahiya added a commit to abhinavdahiya/installer that referenced this pull request Apr 9, 2019
@abhinavdahiya
*: remove the deprecated kube-system coreos-pull-secret
4c19145 
PR openshift#1554 marked kube-system coreos-pull-secret deprecated in favor of openshift-config pull-secret

consumer PRs like openshift/origin#22508 openshift/machine-config-operator#609 should allow removal now.
@abhinavdahiya abhinavdahiya mentioned this pull request Apr 9, 2019
Merged
@openshift-merge-robot openshift-merge-robot merged commit 4f9069a into openshift:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@runcom runcom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhinavdahiya @runcom @kikisdeliveryservice @openshift-ci-robot @openshift-merge-robot