Bug 1697644: *: push pull-secret to openshift-config namespace #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/M
abhinavdahiya
requested review from
kpiwko,
smarterclayton,
staebler and
wking
and removed request for
hardys,
kpiwko and
tomassedovic
staebler
reviewed
Apr 8, 2019
Contributor
staebler
left a comment
staebler
left a comment
There was a problem hiding this comment.
Looks good, save for one small nit.
Contributor
There was a problem hiding this comment.
Even though we don't use the manifest-templates stage any more, this type should be added to the targets for that stage.
This deprecates the kube-system/coreos-pull-secret in favor of openshift-config/pull-secret
abhinavdahiya
force-pushed
the
move-pull-secret
branch
from
7d2775f to
efc027e
Compare
openshift-ci-robot
added
size/XXL
abhinavdahiya
changed the title
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Apr 9, 2019
PR openshift#1554 marked kube-system coreos-pull-secret deprecated in favor of openshift-config pull-secret consumer PRs like openshift/origin#22508 openshift/machine-config-operator#609 should allow removal now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the kube-system/coreos-pull-secret in favor of openshift-config/pull-secret