Skip to content

Bug 1697644: test/extended: update test to use openshift-config pull-secret #22508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 12, 2019
Merged

Bug 1697644: test/extended: update test to use openshift-config pull-secret #22508

openshift-merge-robot merged 1 commit into from
Apr 12, 2019

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Apr 8, 2019

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2019
@abhinavdahiya abhinavdahiya changed the title test/extended: update test to use openshift-config pull-secret Bug 1697644: test/extended: update test to use openshift-config pull-secret Apr 8, 2019
@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Apr 8, 2019

/retest

@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Apr 9, 2019

/refresh

@wking
Copy link
Member

wking commented Apr 9, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
abhinavdahiya added a commit to abhinavdahiya/installer that referenced this pull request Apr 9, 2019
@abhinavdahiya
*: remove the deprecated kube-system coreos-pull-secret
4c19145 
PR openshift#1554 marked kube-system coreos-pull-secret deprecated in favor of openshift-config pull-secret

consumer PRs like openshift/origin#22508 openshift/machine-config-operator#609 should allow removal now.
@abhinavdahiya abhinavdahiya mentioned this pull request Apr 9, 2019
Merged
@smarterclayton
Copy link
Contributor

smarterclayton commented Apr 9, 2019

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2019
@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Apr 9, 2019

/retest

@wking
Copy link
Member

wking commented Apr 10, 2019

Looks like verify failed on the Go 1.11 bump (openshift/release#3394). Maybe that's what's going on with the unit tests too?

$ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/22508/pull-ci-openshift-origin-master-unit/4939/artifacts/unit/unit.log.gz | gunzip | grep GetNameFromCallsite/ignore-package
{"Time":"2019-04-09T23:43:06.158172797Z","Action":"run","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package"}
{"Time":"2019-04-09T23:43:06.158193705Z","Action":"output","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package","Output":"=== RUN   TestGetNameFromCallsite/ignore-package\n"}
{"Time":"2019-04-09T23:43:06.159995273Z","Action":"output","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package","Output":"    --- FAIL: TestGetNameFromCallsite/ignore-package (0.00s)\n"}
{"Time":"2019-04-09T23:43:06.160000271Z","Action":"output","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package","Output":"        from_stack_test.go:52: expected \"testing/testing.go:777\", got \"testing/testing.go:827\"\n"}
{"Time":"2019-04-09T23:43:06.160009673Z","Action":"fail","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package","Elapsed":0}

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor

soltysh commented Apr 10, 2019

Looks like verify failed on the Go 1.11 bump (openshift/release#3394). Maybe that's what's going on with the unit tests too?

Should be fixed by now. @wking ping me if there are some problems still.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Apr 10, 2019

images:

could not wait for RPM repo server to deploy: could not wait for deployment: the deployment config ci-op-5t6fl9c5/rpm-repo failed with status "ProgressDeadlineExceeded"

Hunting...

@wking
Copy link
Member

wking commented Apr 10, 2019

Build history has this as a one-off failure, so kicking again in case it was just a fluke.

/retest

@wking
Copy link
Member

wking commented Apr 10, 2019

images:

could not wait for build: the build node failed after 15m4s with reason BuildPodDeleted: The pod for this build was deleted before the build completed

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 11, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 11, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Apr 12, 2019

unit:

FAIL: github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/podautoscaler TestEventNotCreated 3m0.261s

/test unit

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 02594fa into openshift:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@wking wking

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@abhinavdahiya @wking @smarterclayton @openshift-ci-robot @openshift-bot @soltysh @openshift-merge-robot