Bug 1876810: Rebase v3.0.0 #28
Conversation
This dependency is problematic because of the many replaces it brings with it. This makes it hard to import external-snapshotter in 3rd party projects without having a lot of `replace` directives in those projects as well. The only usage of that import was to get two very simple utility functions so I copied them over to this repo.
Update Error in Snapshot Status
Added the unit tests from https://github.com/kubernetes/kubernetes/blob/master/pkg/util/slice/slice_test.go (minus modifier tests) so we can be sure to not change behaviour.
Irrespective of any error on the Volume Snapshot object, initiate dynamic VolumeSnapshotContent object creation. If any required parameters are not found, (e.g. missing VS class), the VS content object creation would fail gracefully.
Call dynamic VS content creation unconditionally
chore: get rid of k8s.io/kubernetes dep
Adjusted the date printing to address unit test failure
Upgrade to v19
Move to klogv2
Use separate client for leader election
Add steps on promoting release images
Emit event even if status update fails
Go 1.15 was released and is the major version that Kubernetes 1.19.0 is going to use. There are probably bugs in the older 1.13.3 that were fixed, so we should update.
switch to Go 1.15
master: update release-tools
Kubernetes 1.19.0 uses Go 1.15, but refers to it as 1.15.0. This broke both the check whether we need to install 1.15 (because "go version" reports 1.15, which didn't match 1.15.0) and then downloading the release archive (because the URL also only uses 1.15).
Update to v3
- bump controller-gen 0.4.0 version - update CRDs to use `apiextensions.k8s.io/v1` apis Signed-off-by: prateekpandey14 <[email protected]>
Update volume snapshot CRDs to v1 version
Update client library dependency to k8s v1.19
Add changelog for release 3.0
openshift-ci-robot
added
the
approved
|
@jsafrane: This pull request references Bugzilla bug 1876810, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-high
|
/test e2e-ovirt |
|
/retest |
|
/test e2e-aws-csi |
|
/test all |
|
@jsafrane: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jsafrane: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1876810 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
DFBUGS-4252: [release-4.20] add requests and limits to snapshot-controller
14 participants
Rebase to the latest upstream version.
@openshift/storage
Diff to upstream v3.0.0: kubernetes-csi/external-snapshotter@v3.0.0...jsafrane:rebase-v3.0.0
+ bump go version in Dockerfile