Skip to content

chore: get rid of k8s.io/kubernetes dep#334

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
makkes:remove-kubernetes-dep
Jul 24, 2020
Merged

chore: get rid of k8s.io/kubernetes dep#334
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
makkes:remove-kubernetes-dep

Conversation

@makkes
Copy link
Contributor

@makkes makkes commented Jul 21, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

The k8s.io/kubernetes dependency is problematic because of the many replaces it brings with it. This makes it hard to import external-snapshotter in 3rd party projects without having a lot of replace directives in those projects as well.

The only usage of that import was to get two very simple utility functions so I copied them over to this repo.

Which issue(s) this PR fixes:

no issue

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

chore: get rid of k8s.io/kubernetes dep
1f13709 
This dependency is problematic because of the many replaces it brings
with it. This makes it hard to import external-snapshotter in 3rd
party projects without having a lot of `replace` directives in those
projects as well.

The only usage of that import was to get two very simple utility
functions so I copied them over to this repo.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 21, 2020

Welcome @makkes!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 21, 2020

Hi @makkes. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 21, 2020
joejulian
joejulian approved these changes Jul 21, 2020
View reviewed changes
Copy link

@joejulian joejulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes. Please. 🙂

@makkes
Copy link
Contributor Author

makkes commented Jul 21, 2020

/assign @yuxiangqian

@jsafrane
Copy link
Contributor

jsafrane commented Jul 22, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2020
yuxiangqian
yuxiangqian reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@yuxiangqian yuxiangqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, two nits. thnx for fixing.

@makkes
Copy link
Contributor Author

makkes commented Jul 22, 2020 •
edited
Loading

Thanks, @yuxiangqian for reviewing. I have addressed your comments and also added unit tests for the new utility funcs.

@makkes makkes force-pushed the remove-kubernetes-dep branch from a3a0694 to 04848c7 Compare July 22, 2020 07:36
@yuxiangqian
Copy link
Contributor

yuxiangqian commented Jul 22, 2020

lgtm, will wait until all tests passed to approve.

@makkes
Copy link
Contributor Author

makkes commented Jul 23, 2020 •
edited
Loading

@yuxiangqian would you mind having another look, please? 🙇‍♂️

@yuxiangqian
Copy link
Contributor

yuxiangqian commented Jul 24, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makkes, yuxiangqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3c32e28 into kubernetes-csi:master Jul 24, 2020
@makkes makkes deleted the remove-kubernetes-dep branch July 24, 2020 06:54
@makkes makkes mentioned this pull request Oct 23, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

2 more reviewers

@yuxiangqian yuxiangqian yuxiangqian left review comments

@joejulian joejulian joejulian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yuxiangqian yuxiangqian

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@makkes @k8s-ci-robot @jsafrane @yuxiangqian @joejulian