Skip to content

Add changelog for release 3.0#332

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
xing-yang:changelog_2.2.0
Sep 17, 2020
Merged

Add changelog for release 3.0#332
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
xing-yang:changelog_2.2.0

Conversation

@xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Jul 11, 2020 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR adds changelog for 3.0.0.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 11, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from lpabon and saad-ali July 11, 2020 03:49
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2020
@humblec
Copy link
Contributor

humblec commented Jul 19, 2020

lgtm. Thanks!

@xing-yang xing-yang changed the title WIP: Add changelog for release 2.2.0 Add changelog for release 2.2.0 Sep 4, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2020
@xing-yang
Copy link
Collaborator Author

xing-yang commented Sep 4, 2020

/assign @msau42

msau42
msau42 reviewed Sep 4, 2020
View reviewed changes
@xing-yang xing-yang changed the title Add changelog for release 2.2.0 Add changelog for release 3.0 Sep 7, 2020
msau42
msau42 reviewed Sep 10, 2020
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2020
@xing-yang xing-yang mentioned this pull request Sep 14, 2020
Closed
msau42
msau42 reviewed Sep 14, 2020
View reviewed changes
README.md

## CRDs and Client Library

Volume snapshot APIs and client library are now in a separate sub-module: `github.com/kubernetes-csi/external-snapshotter/client/v3`.
Copy link
Collaborator

@msau42 msau42 Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a "go get" command they can use?

Copy link
Collaborator Author

@xing-yang xing-yang Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. "go get -u github.com/kubernetes-csi/external-snapshotter/client/v3@v3.0.0". I'll add that.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2020
@xing-yang xing-yang force-pushed the changelog_2.2.0 branch 2 times, most recently from 12ed0d9 to 5068784 Compare September 16, 2020 05:59
@msau42
Copy link
Collaborator

msau42 commented Sep 16, 2020

/retest
/lgtm
You may need to update the dependencies section again after #376

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2020
@xing-yang
Copy link
Collaborator Author

xing-yang commented Sep 16, 2020

@msau42 I rebased and ran "go mod tidy" and "go mod vendor". No new changes other than the rebase itself.

@msau42
Copy link
Collaborator

msau42 commented Sep 16, 2020

Oh, the latest release-notes tool actually generates a changed dependencies section, example: https://github.com/kubernetes-csi/external-provisioner/blob/master/CHANGELOG/CHANGELOG-2.0.md#dependencies

@xing-yang
Copy link
Collaborator Author

xing-yang commented Sep 16, 2020

Oh, the latest release-notes tool actually generates a changed dependencies section, example: https://github.com/kubernetes-csi/external-provisioner/blob/master/CHANGELOG/CHANGELOG-2.0.md#dependencies

That means the release-notes I have is too old. I'll update it and re-run.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2020
msau42
msau42 reviewed Sep 16, 2020
View reviewed changes
@msau42
Copy link
Collaborator

msau42 commented Sep 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 28abcf9 into kubernetes-csi:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 msau42 left review comments

@lpabon lpabon Awaiting requested review from lpabon

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xing-yang @k8s-ci-robot @humblec @msau42