Skip to content

Bug 1876810: Bump external-snapshotter to v3.0.0#51

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jsafrane:bump-snapshot
Sep 22, 2020
Merged

Bug 1876810: Bump external-snapshotter to v3.0.0#51
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jsafrane:bump-snapshot

Conversation

@jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Sep 18, 2020 •
edited
Loading

  • update to klog/v2
  • bump library-go to the latest version
  • bump kubernetes to the latest version
  • bump go to 1.15
  • bump external-snapshotter client to v3 (with import path change)
    • update CRD definitions from the external-snapshotter to manifest/ assets
      • use apiextensions/v1 instead of v1beta1 as result

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2020

@jsafrane: This pull request references Bugzilla bug 1876810, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1876810: Bump external-snapshotter to v3.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 18, 2020 •
edited
Loading

Unit tests are likely to fail due to github.com/openshift/library-go/pull/896

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 18, 2020

cc @openshift/storage

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 18, 2020

And openshift/release#11992 is needed for new golang

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 18, 2020

/retest
with go 1.15

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 18, 2020

It builds \o/

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 21, 2020

/retest
flakes

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 21, 2020
Merged
bertinatto
bertinatto reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 21, 2020 •
edited
Loading

@jsafrane: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 40c04b3 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1f01430 into openshift:master Sep 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 22, 2020

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 1876810 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1876810: Bump external-snapshotter to v3.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 22, 2020

@jsafrane: Bugzilla bug 1876810 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Bug 1876810: Bump external-snapshotter to v3.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@tsmetana tsmetana Awaiting requested review from tsmetana

1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsafrane @openshift-ci-robot @openshift-bot @bertinatto @openshift-merge-robot