Skip to content

Update to v3#373

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
xing-yang:v3
Sep 14, 2020
Merged

Update to v3#373
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
xing-yang:v3

Conversation

@xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Sep 8, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update volume snapshot APIs and client library to v3. Volume snapshot APIs and client library are in a separate sub-module: `github.com/kubernetes-csi/external-snapshotter/client/v3`.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 8, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 8, 2020
@xing-yang xing-yang changed the title WIP: Update to v3 Update to v3 Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 9, 2020
@xing-yang xing-yang mentioned this pull request Sep 9, 2020
Merged
@ggriffiths
Copy link
Contributor

ggriffiths commented Sep 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2020
@xing-yang
Copy link
Collaborator Author

xing-yang commented Sep 14, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 60202d2 into kubernetes-csi:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@yuxiangqian yuxiangqian Awaiting requested review from yuxiangqian

Assignees

@ggriffiths ggriffiths

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xing-yang @k8s-ci-robot @ggriffiths