Library go bump by eggfoobar · Pull Request #615 · openshift/console-operator

eggfoobar · 2021-12-08T04:01:02Z

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

Changes:

updated library-go to use latest release-4.10 branch
updated method calls to reflect new method signatures with passed in context
updated to use new managementstatecontroller package instead of old managementstate package

openshift-ci · 2021-12-08T04:01:03Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

updated to using latest library-go updated build images to use go 1.17 updated method signatures for library-go methods where context is passed in update test to work with go 1.17 crypto message change Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com>

Signed-off-by: ehila <ehila@redhat.com>

eggfoobar · 2021-12-16T15:37:46Z

/assign @spadgett

pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com>

spadgett

/lgtm

/assign @yapei
for QE regression test

/label px-approved
/label docs-approved
Dependency bump only, no user-visible changes

openshift-bot · 2021-12-17T19:34:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T19:46:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T19:58:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T21:10:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T21:22:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T21:46:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-20T18:19:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-20T18:31:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-20T18:43:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>

Signed-off-by: ehila <ehila@redhat.com>

XiyunZhao · 2021-12-22T12:27:07Z

/lgtm

openshift-ci · 2021-12-22T12:27:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, spadgett, XiyunZhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

XiyunZhao · 2021-12-22T12:27:55Z

/label qe-approved

openshift-bot · 2021-12-22T12:33:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T12:46:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

XiyunZhao · 2021-12-22T12:51:17Z

This PR has been tested and passed. Below listed 4 parts that have been tested, please let me know if any scenario needs more check

Pick up cases and do regression test, the base function of console-operator, like edit URL of logout, switch the state of the console-operator to Removed and change back, basic CLI command and etc. are workable and did not find any issue
No issue found on the related resources, like pod, deployment, configuration that were created by console-operators
No issue found after using different role login to the console, and navigate to related page
No issue found on API when trigger upon function test on console (tracking API on the browser development mode)

openshift-bot · 2021-12-22T14:17:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T15:35:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T16:27:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T17:19:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T17:45:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T20:31:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T20:43:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T22:43:22Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T23:07:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-23T02:31:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-23T02:43:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-12-23T04:31:50Z

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2021

openshift-ci Bot requested review from jhadvig and spadgett December 8, 2021 04:01

eggfoobar changed the title ~~WIP: Library go bump~~ [WIP] Library go bump Dec 13, 2021

eggfoobar marked this pull request as ready for review December 13, 2021 16:35

eggfoobar force-pushed the library_go_bump branch 3 times, most recently from a5fe861 to f5bc508 Compare December 14, 2021 18:11

eggfoobar force-pushed the library_go_bump branch from f5bc508 to d4db61d Compare December 14, 2021 19:35

fix: updated logs component to append log flag

d0194b3

Signed-off-by: ehila <ehila@redhat.com>

eggfoobar changed the title ~~[WIP] Library go bump~~ Library go bump Dec 15, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2021

upkeep: updated to use cli component for cleaner code

a8c352b

Signed-off-by: ehila <ehila@redhat.com>

openshift-ci Bot assigned spadgett Dec 16, 2021

fix: pull in latest library-go

555117d

pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com>

spadgett approved these changes Dec 17, 2021

View reviewed changes

openshift-ci Bot assigned yapei Dec 17, 2021

bump: library-go

450fa5b

updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021

fix: rbac read for infrastructures resource

e2d77a0

Signed-off-by: ehila <ehila@redhat.com>

openshift-ci Bot assigned XiyunZhao Dec 22, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Dec 22, 2021

openshift-merge-robot merged commit acae3a6 into openshift:master Dec 23, 2021

This was referenced Jan 4, 2022

Update version of build machinery to fix make verify PROW job #619

Closed

Fast forward multi cluster feature branch #616

Closed

Conversation

eggfoobar commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Dec 8, 2021

Uh oh!

eggfoobar commented Dec 16, 2021

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Dec 17, 2021

Uh oh!

openshift-bot commented Dec 17, 2021

Uh oh!

openshift-bot commented Dec 17, 2021

Uh oh!

openshift-bot commented Dec 17, 2021

Uh oh!

openshift-bot commented Dec 17, 2021

Uh oh!

openshift-bot commented Dec 17, 2021

Uh oh!

openshift-bot commented Dec 20, 2021

Uh oh!

openshift-bot commented Dec 20, 2021

Uh oh!

openshift-bot commented Dec 20, 2021

Uh oh!

XiyunZhao commented Dec 22, 2021

Uh oh!

openshift-ci Bot commented Dec 22, 2021

Uh oh!

XiyunZhao commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

XiyunZhao commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 23, 2021

Uh oh!

openshift-bot commented Dec 23, 2021

Uh oh!

openshift-ci Bot commented Dec 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eggfoobar commented Dec 8, 2021 •

edited

Loading