Skip to content

Fast forward multi cluster feature branch#616

Closed
TheRealJon wants to merge 18 commits intoopenshift:master-multi-cluster-featurefrom
TheRealJon:master-multi-cluster-feature-ff
Closed

Fast forward multi cluster feature branch#616
TheRealJon wants to merge 18 commits intoopenshift:master-multi-cluster-featurefrom
TheRealJon:master-multi-cluster-feature-ff

Conversation

@TheRealJon
Copy link
Copy Markdown
Member

@TheRealJon TheRealJon commented Dec 8, 2021

No description provided.

JPinkney and others added 17 commits September 10, 2021 13:21
@JPinkney
Change web terminal subscription permissions from get to list
84d500a 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@jhadvig
Bug 2008185: Console operator go.mod should use go 1.16 version
93e3e99
@openshift-merge-robot
Merge pull request openshift#588 from JPinkney/web-terminal-permissions
6c08cb7 
Bug 2009454: Change web terminal subscription permissions from get to list
manifests: resources required for adding helm metrics in console
3b91735 
Adds a new ServiceMonitor to allow the Helm metrics being scraped from
console /metrics endpoint by prometheus-k8s.

Closes: https://issues.redhat.com/browse/HELM-235
Reference: openshift#270
Signed-off-by: Allen Bai <abai@redhat.com>
@openshift-merge-robot
Merge pull request openshift#597 from jhadvig/bz2008185
13fd0c8 
Bug 2008185: Console operator go.mod should use go 1.16 version
@SanjalKatiyar
Bug 2004916: corrections in ODF QuickStart guide
e4838f3 
This will make Correction/Changes in Install ODF Quick Start Guide
manifests: update according to reviews
594233a 
Signed-off-by: Allen Bai <abai@redhat.com>
@openshift-merge-robot
Merge pull request openshift#598 from SanjalKatiyar/edit_ODF_quickstart
107511d 
Bug 2013632: Correction/Changes in Quick Start Guides for ODF
@openshift-merge-robot
Merge pull request openshift#601 from zonggen/helm-metrics-resources
02ba53a 
manifests: resources required for adding helm metrics in console
@yselkowitz
Migrate docs links to access.redhat.com
b5fb765
@openshift-merge-robot
Merge pull request openshift#607 from multi-arch/4.10-docs-links
58953a9 
Bug 2018380: Migrate docs links to access.redhat.com
@jhadvig
Bug 2013632: Correct grammar error in ODF quickstart
3b80496
@openshift-merge-robot
Merge pull request openshift#608 from jhadvig/bz2013632
f77dabb 
Bug 2013632: Correct grammar error in ODF quickstart
@jhadvig
CONSOLE-2892: Allow dynamic plugins to proxy to services on the cluster
fc1df9b
@openshift-merge-robot
Merge pull request openshift#603 from jhadvig/CONSOLE-2892
4583855 
CONSOLE-2892: Allow dynamic plugins to proxy to services on the cluster
@jhadvig
Bug 2021400: Bump documentationBaseURL to 4.10
ef8034a
@openshift-merge-robot
Merge pull request openshift#611 from jhadvig/bz2021400
d68cd6c 
Bug 2021400: Bump documentationBaseURL to 4.10
@openshift-ci openshift-ci Bot requested review from jhadvig and spadgett December 8, 2021 18:11
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TheRealJon
To complete the pull request process, please assign jhadvig after the PR has been reviewed.
You can assign the PR to them by writing /assign @jhadvig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TheRealJon TheRealJon force-pushed the master-multi-cluster-feature-ff branch from 6610720 to d62440e Compare December 8, 2021 19:09
@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Dec 8, 2021

/retest

5 similar comments
@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Dec 9, 2021

/retest

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Dec 9, 2021

/retest

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Dec 9, 2021

/retest

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Dec 10, 2021

/retest

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Dec 13, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 13, 2021

@TheRealJon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator d62440e link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@florkbr
Copy link
Copy Markdown
Contributor

florkbr commented Jan 4, 2022

@TheRealJon the fix for the failing verify job on master was merged in on #615. Did you want to include that PR in this fast forward? Or should I open a PR with the fix I had opened in #619 against master-multi-cluster-feature?

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 4, 2022

@florkbr I'm going to close this PR. I think there is a legit test failure happening and rather than try to fix it here, I'm going to address the issue in #612

@TheRealJon TheRealJon closed this Jan 4, 2022
@TheRealJon TheRealJon deleted the master-multi-cluster-feature-ff branch February 4, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@spadgett spadgett Awaiting requested review from spadgett

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@TheRealJon @florkbr @JPinkney @jhadvig @openshift-merge-robot @SanjalKatiyar @yselkowitz