Skip to content

Conversation

@mdbooth
Copy link

@mdbooth mdbooth commented Sep 29, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


pierreprinetti and others added 30 commits March 29, 2022 16:14
Merge upstream kubernetes-sigs/cluster-api-provider-openstack
Update from kubernetes-sigs/cluster-api-provider-openstack
…ot/cherry-pick-1226-to-release-0.6

[release-0.6] 🌱 Add release 0.6.x to metadata.yaml
…ot/cherry-pick-1231-to-release-0.6

[release-0.6] 🐛 Fix nil pointer reference during bastion deletion
…ot/cherry-pick-1233-to-release-0.6

[release-0.6] move chrischdi to emeritus_approvers
* as we already have webhooks for v1alpha5 we don't need webhooks for
older versions anymore.
* remove v1alpha4 from webhook mgr setup
* remove defaultIdentityRefKind const in v1alpha4

Signed-off-by: Mario Constanti <[email protected]>
…ot/cherry-pick-1240-to-release-0.6

[release-0.6]  🐛 remove webhooks for old APIversion v1alpha4
this is notes from my setup, it can be useful for folks who want to
develop CAPO with a single devstack instance.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
The change to generated go build metadata requires a small change in
boilerplate verification.
mdbooth and others added 16 commits September 26, 2023 14:12
🌱 Move webhook CA injection into webhook resource
CAPO doesn't use vendoring, so let's ignore that directory from git.
That will prevent someone from committing it.
…ator

Conflicts:
	OWNERS
	OWNERS_ALIASES
	api/v1alpha7/openstackcluster_webhook.go
	api/v1alpha7/openstackcluster_webhook_test.go
	api/v1alpha7/openstackclusterlist_webhook.go
	api/v1alpha7/openstackclustertemplate_webhook.go
	api/v1alpha7/openstackmachine_webhook.go
	api/v1alpha7/openstackmachinelist_webhook.go
	api/v1alpha7/openstackmachinetemplate_webhook_test.go
	api/v1alpha7/openstackmachinetemplatelist_webhook.go
	api/v1alpha7/webhooks.go
	config/webhook/manifests.yaml
	controllers/openstackcluster_controller.go
	metadata.yaml
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mdbooth. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2023
@pierreprinetti
Copy link
Member

What is this?

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2023

@mdbooth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit e13e164 link false /test unit
ci/prow/test e13e164 link true /test test
ci/prow/images e13e164 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-merge-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbooth mdbooth closed this Oct 5, 2023
@mdbooth mdbooth deleted the cluster-capi-operator branch October 5, 2023 16:43
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
some folder not workable through relative path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.