Skip to content

Conversation

@pierreprinetti
Copy link
Member

No description provided.

Matt Pryor and others added 7 commits May 3, 2022 07:59
…ot/cherry-pick-1231-to-release-0.6

[release-0.6] 🐛 Fix nil pointer reference during bastion deletion
…ot/cherry-pick-1233-to-release-0.6

[release-0.6] move chrischdi to emeritus_approvers
* as we already have webhooks for v1alpha5 we don't need webhooks for
older versions anymore.
* remove v1alpha4 from webhook mgr setup
* remove defaultIdentityRefKind const in v1alpha4

Signed-off-by: Mario Constanti <[email protected]>
…ot/cherry-pick-1240-to-release-0.6

[release-0.6]  🐛 remove webhooks for old APIversion v1alpha4
@openshift-ci openshift-ci bot requested review from mdbooth and stephenfin September 8, 2022 10:54
@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2022

@pierreprinetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 614f2cf link false /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member

EmilienM commented Sep 8, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit ef44b7e into openshift:main Sep 8, 2022
@pierreprinetti pierreprinetti deleted the merge_upstream branch September 8, 2022 13:55
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
This changes provide security groups removal
during cluster deletion if managedSecurityGroups
is true in clusterSpec.providerSpec

Change-Id: I62002e50ae7c60b7fda38663118f8deabb03ba3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants