Skip to content

Downstream owners #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mandre merged 1 commit into from
Apr 4, 2022
Merged

Downstream owners #229

mandre merged 1 commit into from
Apr 4, 2022

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Apr 4, 2022

No description provided.

@openshift-ci openshift-ci bot requested a review from mdbooth April 4, 2022 07:08
@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mdbooth after the PR has been reviewed.
You can assign the PR to them by writing /assign @mdbooth in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2022

@pierreprinetti: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre
mandre reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
This allows our team to manage the downstream fork of CAPO and merge sync PRs.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@mandre mandre merged commit d7d1be2 into openshift:main Apr 4, 2022
@pierreprinetti pierreprinetti deleted the owners branch April 4, 2022 08:19
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@luis5tb @pierreprinetti
Ensure trunk is not enabled if there is no support (openshift#229)
b8ced75 
This PR ensures trunk cannot be set if the system doesn't have trunk
support. This will avoid leaving orphan ports when failing to create
the trunk for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mandre mandre

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pierreprinetti @mandre