Update from kubernetes-sigs/cluster-api-provider-openstack #230
Conversation
The controller test suite was disabled due to missing kubebuilder assets. These are now installed before running the tests. A simple sanity check test is also added to confirm that envTest is working.
…ontroller-tests 🏃 Enable controller tests
🏃 Explain mutability of bastion configuration in CRD
Common network and security group handling between CreateBastion() and CreateInstance(). A principal advantage of this refactor is that it makes the marshalling of OpenStackMachineSpec and Instance respectively into an InstanceSpec a cheap operation which makes no API calls.
Refactor instance creation in machine controller and cluster controller (for the bastion) to call compute.CreateInstance() with an InstanceSpec.
…ruct⚠️ move loadbalancer opts to struct
✨Refactor CreateInstance and CreateBastion
|
/skip ci/prow/unit |
|
/retest |
|
@mandre Please could you force-merge or override this test failure? |
|
For context, the unit tests are failing because the merge pulls in kubernetes-sigs#1183, which enables envtests. This PR made changes to the This test failure is just noise and inconvenience right now as:
I understand there was some reason that |
|
/override ci/prow/unit Let's see if this works…? |
|
@dulek: dulek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
And it's merged, what now? ;) |
It's not :P |
|
/retest |
|
@dulek: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hmm. How do we make that test no longer required? |
|
I'd just try |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
7 participants
Update from kubernetes-sigs/cluster-api-provider-openstack.