Skip to content

Bug 1954177: revert pending webhook tests #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 18, 2021
Merged

Bug 1954177: revert pending webhook tests #211

openshift-merge-robot merged 1 commit into from
May 18, 2021

Conversation

@elmiko
Copy link
Contributor

@elmiko elmiko commented May 4, 2021 •
edited
Loading

This change reverts the changes added in #210 to re-enable the webhook tests.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2021

@elmiko: This pull request references Bugzilla bug 1954177, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1954177: Update mao dependency and revert pending webhook tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 4, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from elmiko after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Danil-Grigorev
Copy link

Danil-Grigorev commented May 4, 2021

There are some govet failures - https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-api-actuator-pkg/211/pull-ci-openshift-cluster-api-actuator-pkg-master-govet/1389599939859845120 :/

@elmiko
Copy link
Contributor Author

elmiko commented May 4, 2021

/hold
this is going to need to wait until the providers have been re-vendored, then we can re-vendor here. the conflicts are coming from the other providers.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021
This was referenced May 4, 2021
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 5, 2021
Merged
@openshift-ci openshift-ci bot mentioned this pull request May 7, 2021
Merged
@elmiko elmiko force-pushed the update-mao-dependency branch from b941ac0 to 1c556cd Compare May 7, 2021 17:48
@elmiko
Copy link
Contributor Author

elmiko commented May 7, 2021

updated

  • revendor mao, cao, aws, azure, and gcp
  • add fixes for vendor changes

@openshift-ci openshift-ci bot mentioned this pull request May 10, 2021
Merged
@elmiko
Copy link
Contributor Author

elmiko commented May 11, 2021

/retest

@openshift-ci openshift-ci bot mentioned this pull request May 11, 2021
Merged
@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 12, 2021

/retest

@elmiko
Copy link
Contributor Author

elmiko commented May 12, 2021

@JoelSpeed is this a flake? it seems to keep failing the same test but with different values.

@elmiko elmiko mentioned this pull request May 12, 2021
Merged
@elmiko
Copy link
Contributor Author

elmiko commented May 12, 2021

as #209 has been updated and now includes these vendor changes, i am updating this PR to only revert the pending webhook tests.

@elmiko
unmark webhook tests as pending
72f2a1b 
This reverts openshift#210 as the vendoring has been completed in MAO.
@elmiko elmiko force-pushed the update-mao-dependency branch from 1c556cd to 72f2a1b Compare May 12, 2021 16:38
@elmiko elmiko changed the title Bug 1954177: Update mao dependency and revert pending webhook tests Bug 1954177: revert pending webhook tests May 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2021

@elmiko: This pull request references Bugzilla bug 1954177, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1954177: revert pending webhook tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented May 12, 2021

this will still need to wait until #209 has merged

@openshift-ci openshift-ci bot mentioned this pull request May 15, 2021
Merged
@elmiko
Copy link
Contributor Author

elmiko commented May 17, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2021
@Danil-Grigorev
Copy link

Danil-Grigorev commented May 17, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@lobziik
Copy link
Contributor

lobziik commented May 17, 2021

/retest

1 similar comment
@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 18, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2021 •
edited
Loading

@elmiko: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-operator 72f2a1b link /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot mentioned this pull request May 18, 2021
Merged
@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 18, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1eabf10 into openshift:master May 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2021

@elmiko: All pull requests linked via external trackers have merged:

Bugzilla bug 1954177 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1954177: revert pending webhook tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko deleted the update-mao-dependency branch May 18, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@enxebre enxebre Awaiting requested review from enxebre

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elmiko @openshift-ci-robot @Danil-Grigorev @JoelSpeed @lobziik @openshift-merge-robot