Skip to content

Bug 1954177: update AdmissionReviewVersions to v1 #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 4, 2021
Merged

Bug 1954177: update AdmissionReviewVersions to v1 #855

openshift-merge-robot merged 1 commit into from
May 4, 2021

Conversation

@elmiko
Copy link
Contributor

@elmiko elmiko commented Apr 27, 2021

admissionReviewVersions v1beta1 is going to be removed in kubernetes
1.22, this change bumps the version from v1beta1 to v1.

@elmiko
update AdmissionReviewVersions to v1
b7524c0 
admissionReviewVersions v1beta1 is going to be removed in kubernetes
1.22, this change bumps the version from v1beta1 to v1.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 27, 2021

@elmiko: This pull request references Bugzilla bug 1954177, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1954177: update AdmissionReviewVersions to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 27, 2021
JoelSpeed
JoelSpeed reviewed Apr 28, 2021
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Apr 28, 2021

/retest

@elmiko elmiko mentioned this pull request Apr 28, 2021
Merged
alexander-demicev
alexander-demicev approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

elmiko added a commit to elmiko/cluster-api-actuator-pkg that referenced this pull request May 3, 2021
@elmiko
mark webhook tests as pending
19d89ea 
This change adds the `P` prefix to the `It` clauses for the webhook
tests. This is being done temporarily to allow for MAO webhook
dependency changes to pass the test suite, then they will be revendored
into the test suite, at which point the tests will be re-enabled.

ref: openshift/machine-api-operator#855
@elmiko elmiko mentioned this pull request May 3, 2021
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@elmiko
Copy link
Contributor Author

elmiko commented May 3, 2021

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2021

@elmiko: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt b7524c0 link /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a132ec0 into openshift:master May 4, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 4, 2021

@elmiko: All pull requests linked via external trackers have merged:

Bugzilla bug 1954177 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1954177: update AdmissionReviewVersions to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko deleted the bz1954177-ARV-ver-bump branch May 4, 2021 01:41
elmiko added a commit to elmiko/cluster-api-provider-ovirt that referenced this pull request May 5, 2021
@elmiko
udpate mao dependencies
ef674c9 
This change updates the machine-api-operator dependency to pickup
changes for the AdmissionReviewVersions for webhooks.

ref: openshift/machine-api-operator#855
@elmiko elmiko mentioned this pull request May 5, 2021
Merged
elmiko added a commit to elmiko/cluster-api-provider-ovirt that referenced this pull request May 10, 2021
@elmiko
udpate mao dependencies
8f81281 
This change updates the machine-api-operator dependency to pickup
changes for the AdmissionReviewVersions for webhooks.

ref: openshift/machine-api-operator#855
@openshift-ci openshift-ci bot mentioned this pull request May 18, 2021
Merged
elmiko added a commit to elmiko/cluster-api-actuator-pkg that referenced this pull request Oct 26, 2022
@elmiko
mark webhook tests as pending
380beb1 
This change adds the `P` prefix to the `It` clauses for the webhook
tests. This is being done temporarily to allow for MAO webhook
dependency changes to pass the test suite, then they will be revendored
into the test suite, at which point the tests will be re-enabled.

ref: openshift/machine-api-operator#855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@Danil-Grigorev Danil-Grigorev Awaiting requested review from Danil-Grigorev

+1 more reviewer

@alexander-demicev alexander-demicev alexander-demicev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexander-demicev alexander-demicev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elmiko @openshift-ci-robot @JoelSpeed @openshift-bot @alexander-demicev @openshift-merge-robot